Add GUARDED_BY in DirectTransport

Add GUARDED_BY in DirectTransport

Add GUARDED_BY annotation to DirectTransport to demonstrate that next_scheduled_task_ is properly protected.
SendRtp(), SendRtcp(), etc., remain as unprotected as they were before the migration from using a thread to using a task-queue.

BUG=webrtc:8113
TBR=stefan@webrtc.org

Review-Url: https://codereview.webrtc.org/3002163003
Cr-Commit-Position: refs/heads/master@{#19487}
Committed: https://chromium.googlesource.com/external/webrtc/+/cff98dc2d6a4239fee83f90c9f48e86382f4e244

[eladalon, 2017-08-24 08:31:10]

eladalon@webrtc.org changed reviewers:
+ danilchap@webrtc.org, stefan@webrtc.org

[eladalon, 2017-08-24 08:31:12]

PTAL

[danilchap, 2017-08-24 10:39:08]

lgtm

https://codereview.webrtc.org/3002163003/diff/1/webrtc/test/direct_transport.h
File webrtc/test/direct_transport.h (right):

https://codereview.webrtc.org/3002163003/diff/1/webrtc/test/direct_transport....
webrtc/test/direct_transport.h:31: // Objects of this class are expected to be
allocated, used, then destroyed
used too?
I was sure it is ok to call SendRtp function from outside of the task queue.

[eladalon, 2017-08-24 11:00:21]

https://codereview.webrtc.org/3002163003/diff/1/webrtc/test/direct_transport.h
File webrtc/test/direct_transport.h (right):

https://codereview.webrtc.org/3002163003/diff/1/webrtc/test/direct_transport....
webrtc/test/direct_transport.h:31: // Objects of this class are expected to be
allocated, used, then destroyed
On 2017/08/24 10:39:08, danilchap wrote:
> used too?
> I was sure it is ok to call SendRtp function from outside of the task queue.

I've revised the wording.

[eladalon, 2017-08-24 11:00:34]

Description was changed from

==========
Add GUARDED_BY in DirectTransport

Add GUARDED_BY annotation to DirectTransport to demonstrate that
next_scheduled_task_ is properly protected.
SendRtp(), SendRtcp(), etc., remain as unprotected as they were before the
migration from using a thread to using a task-queue.

BUG=webrtc:8113
==========

to

==========
Add GUARDED_BY in DirectTransport

Add GUARDED_BY annotation to DirectTransport to demonstrate that
next_scheduled_task_ is properly protected.
SendRtp(), SendRtcp(), etc., remain as unprotected as they were before the
migration from using a thread to using a task-queue.

BUG=webrtc:8113
TBR=stefan@webrtc.org
==========

[eladalon, 2017-08-24 11:00:39]

The CQ bit was checked by eladalon@webrtc.org

[eladalon, 2017-08-24 11:00:40]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3002163003/#ps20001 (title:
".")

[commit-bot: I haz the power, 2017-08-24 11:00:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-24 12:04:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1503572439348680,
"parent_rev": "a4955b4d9a0ef84ffe1aa262a38f77740f53fa4d", "commit_rev":
"cff98dc2d6a4239fee83f90c9f48e86382f4e244"}

[commit-bot: I haz the power, 2017-08-24 12:05:03]

Description was changed from

==========
Add GUARDED_BY in DirectTransport

Add GUARDED_BY annotation to DirectTransport to demonstrate that
next_scheduled_task_ is properly protected.
SendRtp(), SendRtcp(), etc., remain as unprotected as they were before the
migration from using a thread to using a task-queue.

BUG=webrtc:8113
TBR=stefan@webrtc.org
==========

to

==========
Add GUARDED_BY in DirectTransport

Add GUARDED_BY annotation to DirectTransport to demonstrate that
next_scheduled_task_ is properly protected.
SendRtp(), SendRtcp(), etc., remain as unprotected as they were before the
migration from using a thread to using a task-queue.

BUG=webrtc:8113
TBR=stefan@webrtc.org

Review-Url: https://codereview.webrtc.org/3002163003
Cr-Commit-Position: refs/heads/master@{#19487}
Committed:
https://chromium.googlesource.com/external/webrtc/+/cff98dc2d6a4239fee83f90c9...
==========

[commit-bot: I haz the power, 2017-08-24 12:05:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/cff98dc2d6a4239fee83f90c9...