Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Unified Diff: webrtc/test/direct_transport.h

Issue 3002163003: Add GUARDED_BY in DirectTransport (Closed)
Patch Set: . Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/test/direct_transport.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/direct_transport.h
diff --git a/webrtc/test/direct_transport.h b/webrtc/test/direct_transport.h
index 93ba97155ae8cf5063da53c22a2c2351eeee284f..4be00a77e0c35670432d449563e109e30608dcdf 100644
--- a/webrtc/test/direct_transport.h
+++ b/webrtc/test/direct_transport.h
@@ -17,6 +17,7 @@
#include "webrtc/api/call/transport.h"
#include "webrtc/call/call.h"
#include "webrtc/rtc_base/sequenced_task_checker.h"
+#include "webrtc/rtc_base/thread_annotations.h"
#include "webrtc/test/fake_network_pipe.h"
#include "webrtc/test/single_threaded_task_queue.h"
@@ -27,6 +28,8 @@ class PacketReceiver;
namespace test {
+// Objects of this class are expected to be allocated and destroyed on the
+// same task-queue - the one that's passed in via the constructor.
class DirectTransport : public Transport {
public:
RTC_DEPRECATED DirectTransport(
@@ -102,7 +105,8 @@ class DirectTransport : public Transport {
// TODO(eladalon): Make |task_queue_| const.
// https://bugs.chromium.org/p/webrtc/issues/detail?id=8125
SingleThreadedTaskQueueForTesting* task_queue_;
- SingleThreadedTaskQueueForTesting::TaskId next_scheduled_task_;
+ SingleThreadedTaskQueueForTesting::TaskId next_scheduled_task_
+ GUARDED_BY(&sequence_checker_);
FakeNetworkPipe fake_network_;
« no previous file with comments | « no previous file | webrtc/test/direct_transport.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698