iSAC floating-point implementation of the Audio{En,De}coderFactoryTemplate APIs

iSAC floating-point implementation of the Audio{En,De}coderFactoryTemplate APIs

BUG=webrtc:7835, webrtc:7841
Review-Url: https://codereview.webrtc.org/3001483002
Cr-Commit-Position: refs/heads/master@{#19427}
Committed: https://chromium.googlesource.com/external/webrtc/+/e57556c764b30c03ab7da3c5fee56cf105306dd6

[kwiberg-webrtc, 2017-08-10 00:17:10]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-10 00:17:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-08-10 00:19:15]

kwiberg@webrtc.org changed reviewers:
+ ossu@webrtc.org

[commit-bot: I haz the power, 2017-08-10 01:17:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-10 01:17:50]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-08-10 12:40:08]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-10 12:40:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-10 13:27:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-10 13:27:46]

Dry run: Try jobs failed on following builders:
  android_compile_mips_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_mips_db...)

[ossu, 2017-08-15 14:04:19]

A couple of comments that apply to this CL and the fixed point one as well.

https://codereview.webrtc.org/3001483002/diff/20001/webrtc/api/audio_codecs/i...
File webrtc/api/audio_codecs/isac/audio_encoder_isac_float.cc (right):

https://codereview.webrtc.org/3001483002/diff/20001/webrtc/api/audio_codecs/i...
webrtc/api/audio_codecs/isac/audio_encoder_isac_float.cc:19:
rtc::Optional<AudioEncoderIsacFloat::Config> AudioEncoderIsacFloat::SdpToConfig(
This one should use (or at least be equivalent to) CreateIsacConfig, so that it
picks up ptime properly (and possibly the ibitrate and maxbitrate parameters,
should we add in support for them).

https://codereview.webrtc.org/3001483002/diff/20001/webrtc/api/audio_codecs/i...
File webrtc/api/audio_codecs/isac/audio_encoder_isac_float.h (right):

https://codereview.webrtc.org/3001483002/diff/20001/webrtc/api/audio_codecs/i...
webrtc/api/audio_codecs/isac/audio_encoder_isac_float.h:23: // iSACfloat encoder
API for use as a template parameter to
Perhaps rephrase this one as "Floating point iSAC encoder[...]" and similar for
the decoder and the fixed point variant in the other CL?

[kwiberg-webrtc, 2017-08-17 13:32:40]

I applied the updates, but didn't upload a new patch set yet. I thought we could
finish with the fixed-point CL first, since that one comes first in my CL stack
and I have no particular urge to deal with the merge conflicts that will ensue
if I reshuffle them.

https://codereview.webrtc.org/3001483002/diff/20001/webrtc/api/audio_codecs/i...
File webrtc/api/audio_codecs/isac/audio_encoder_isac_float.cc (right):

https://codereview.webrtc.org/3001483002/diff/20001/webrtc/api/audio_codecs/i...
webrtc/api/audio_codecs/isac/audio_encoder_isac_float.cc:19:
rtc::Optional<AudioEncoderIsacFloat::Config> AudioEncoderIsacFloat::SdpToConfig(
On 2017/08/15 14:04:19, ossu wrote:
> This one should use (or at least be equivalent to) CreateIsacConfig, so that
it
> picks up ptime properly (and possibly the ibitrate and maxbitrate parameters,
> should we add in support for them).

Done.

https://codereview.webrtc.org/3001483002/diff/20001/webrtc/api/audio_codecs/i...
File webrtc/api/audio_codecs/isac/audio_encoder_isac_float.h (right):

https://codereview.webrtc.org/3001483002/diff/20001/webrtc/api/audio_codecs/i...
webrtc/api/audio_codecs/isac/audio_encoder_isac_float.h:23: // iSACfloat encoder
API for use as a template parameter to
On 2017/08/15 14:04:19, ossu wrote:
> Perhaps rephrase this one as "Floating point iSAC encoder[...]" and similar
for
> the decoder and the fixed point variant in the other CL?

Done.

[kwiberg-webrtc, 2017-08-21 11:47:49]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 11:47:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-08-21 12:38:08]

Updated this one to match iSAC float. Please have a look!

[commit-bot: I haz the power, 2017-08-21 12:39:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 12:39:26]

Dry run: This issue passed the CQ dry run.

[ossu, 2017-08-21 13:06:20]

Alright! LGTM!

[kwiberg-webrtc, 2017-08-21 13:08:49]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-08-21 13:08:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-21 13:11:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1503320929165360,
"parent_rev": "0069b4517966c3a547dafcf4086f9ff30f1bbfc7", "commit_rev":
"e57556c764b30c03ab7da3c5fee56cf105306dd6"}

[commit-bot: I haz the power, 2017-08-21 13:11:28]

Description was changed from

==========
iSAC floating-point implementation of the Audio{En,De}coderFactoryTemplate APIs

BUG=webrtc:7835, webrtc:7841
==========

to

==========
iSAC floating-point implementation of the Audio{En,De}coderFactoryTemplate APIs

BUG=webrtc:7835, webrtc:7841

Review-Url: https://codereview.webrtc.org/3001483002
Cr-Commit-Position: refs/heads/master@{#19427}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e57556c764b30c03ab7da3c5f...
==========

[commit-bot: I haz the power, 2017-08-21 13:11:29]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/e57556c764b30c03ab7da3c5f...