Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc

Issue 3001483002: iSAC floating-point implementation of the Audio{En,De}coderFactoryTemplate APIs (Closed)
Patch Set: review comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/audio_codecs/test/audio_decoder_factory_template_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc
diff --git a/webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc b/webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc
index 4120978291aa408f8f7db74a82befec1a19e29b1..7d8f3a8f950f815959bdf1bafb75bf1734d6027e 100644
--- a/webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc
+++ b/webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc
@@ -14,6 +14,7 @@
#include "webrtc/api/audio_codecs/g722/audio_encoder_g722.h"
#include "webrtc/api/audio_codecs/ilbc/audio_encoder_ilbc.h"
#include "webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.h"
+#include "webrtc/api/audio_codecs/isac/audio_encoder_isac_float.h"
#include "webrtc/api/audio_codecs/opus/audio_encoder_opus.h"
#include "webrtc/rtc_base/ptr_util.h"
#include "webrtc/test/gmock.h"
@@ -181,6 +182,8 @@ TEST(AudioEncoderFactoryTemplateTest, IsacFix) {
factory->QueryAudioEncoder({"isac", 16000, 2}));
EXPECT_EQ(rtc::Optional<AudioCodecInfo>({16000, 1, 32000, 10000, 32000}),
factory->QueryAudioEncoder({"isac", 16000, 1}));
+ EXPECT_EQ(rtc::Optional<AudioCodecInfo>(),
+ factory->QueryAudioEncoder({"isac", 32000, 1}));
EXPECT_EQ(nullptr, factory->MakeAudioEncoder(17, {"isac", 8000, 1}));
auto enc1 = factory->MakeAudioEncoder(17, {"isac", 16000, 1});
ASSERT_NE(nullptr, enc1);
@@ -192,6 +195,28 @@ TEST(AudioEncoderFactoryTemplateTest, IsacFix) {
EXPECT_EQ(6u, enc2->Num10MsFramesInNextPacket());
}
+TEST(AudioEncoderFactoryTemplateTest, IsacFloat) {
+ auto factory = CreateAudioEncoderFactory<AudioEncoderIsacFloat>();
+ EXPECT_THAT(
+ factory->GetSupportedEncoders(),
+ testing::ElementsAre(
+ AudioCodecSpec{{"ISAC", 16000, 1}, {16000, 1, 32000, 10000, 32000}},
+ AudioCodecSpec{{"ISAC", 32000, 1}, {32000, 1, 56000, 10000, 56000}}));
+ EXPECT_EQ(rtc::Optional<AudioCodecInfo>(),
+ factory->QueryAudioEncoder({"isac", 16000, 2}));
+ EXPECT_EQ(rtc::Optional<AudioCodecInfo>({16000, 1, 32000, 10000, 32000}),
+ factory->QueryAudioEncoder({"isac", 16000, 1}));
+ EXPECT_EQ(rtc::Optional<AudioCodecInfo>({32000, 1, 56000, 10000, 56000}),
+ factory->QueryAudioEncoder({"isac", 32000, 1}));
+ EXPECT_EQ(nullptr, factory->MakeAudioEncoder(17, {"isac", 8000, 1}));
+ auto enc1 = factory->MakeAudioEncoder(17, {"isac", 16000, 1});
+ ASSERT_NE(nullptr, enc1);
+ EXPECT_EQ(16000, enc1->SampleRateHz());
+ auto enc2 = factory->MakeAudioEncoder(17, {"isac", 32000, 1});
+ ASSERT_NE(nullptr, enc2);
+ EXPECT_EQ(32000, enc2->SampleRateHz());
+}
+
TEST(AudioEncoderFactoryTemplateTest, L16) {
auto factory = CreateAudioEncoderFactory<AudioEncoderL16>();
EXPECT_THAT(
« no previous file with comments | « webrtc/api/audio_codecs/test/audio_decoder_factory_template_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698