Make a friendlier RTCVideoCodecInfo initializer.

Make a friendlier RTCVideoCodecInfo initializer for when only name and
parameters are interesting.

Since this is used by users when implementing injectable Obj-C video
codecs, the API where the unused payload is required is unnecessarily
confusing. Also make the codec parameters optional.

BUG=None

Review-Url: https://codereview.webrtc.org/3001183002
Cr-Commit-Position: refs/heads/master@{#19411}
Committed: https://chromium.googlesource.com/external/webrtc/+/81bc523f5d7eab43796373954b2aaf17fa65ad35

[andersc, 2017-08-18 11:46:19]

Description was changed from

==========
Make a friendlier RTCVideoCodecInfo initializer for when only name and
parameters are interesting.

Since this is used by users when implementing injectable Obj-C video
codecs, the API where the unused payload is required is unnecessarily
confusing. Also make the codec parameters optional.

BUG=None
==========

to

==========
Make a friendlier RTCVideoCodecInfo initializer for when only name and
parameters are interesting.

Since this is used by users when implementing injectable Obj-C video
codecs, the API where the unused payload is required is unnecessarily
confusing. Also make the codec parameters optional.

BUG=None
==========

[andersc, 2017-08-18 11:46:20]

andersc@webrtc.org changed reviewers:
+ kthelgason@webrtc.org

[andersc, 2017-08-18 11:46:58]

The CQ bit was checked by andersc@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-18 11:47:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-18 11:50:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-18 11:50:57]

Dry run: Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)

[andersc, 2017-08-18 12:03:32]

The CQ bit was checked by andersc@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-18 12:03:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kthelgason, 2017-08-18 12:25:44]

lgtm, boat it!

https://codereview.webrtc.org/3001183002/diff/20001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h (right):

https://codereview.webrtc.org/3001183002/diff/20001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h:107:
parameters:(NSDictionary<NSString *, NSString *> *)parameters
Are we ever expecting this to be called for any reason?

[commit-bot: I haz the power, 2017-08-18 12:29:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-18 12:29:30]

Dry run: Try jobs failed on following builders:
  ios_api_framework on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...)

[andersc, 2017-08-18 12:55:50]

The CQ bit was checked by andersc@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-18 12:55:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[andersc, 2017-08-18 13:30:37]

https://codereview.webrtc.org/3001183002/diff/20001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h (right):

https://codereview.webrtc.org/3001183002/diff/20001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h:107:
parameters:(NSDictionary<NSString *, NSString *> *)parameters
On 2017/08/18 12:25:44, kthelgason wrote:
> Are we ever expecting this to be called for any reason?

You're right, this is only used internally. Moving it to the private header
instead.

[commit-bot: I haz the power, 2017-08-18 13:31:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-18 13:31:09]

Dry run: This issue passed the CQ dry run.

[andersc, 2017-08-18 13:31:42]

The CQ bit was checked by andersc@webrtc.org

[andersc, 2017-08-18 13:31:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
kthelgason@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3001183002/#ps60001 (title:
"Rebase")

[commit-bot: I haz the power, 2017-08-18 13:31:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-18 13:34:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1503063102335330,
"parent_rev": "3042c2d5e0e400d96437e041151995fd96f46ff4", "commit_rev":
"81bc523f5d7eab43796373954b2aaf17fa65ad35"}

[commit-bot: I haz the power, 2017-08-18 13:34:19]

Description was changed from

==========
Make a friendlier RTCVideoCodecInfo initializer for when only name and
parameters are interesting.

Since this is used by users when implementing injectable Obj-C video
codecs, the API where the unused payload is required is unnecessarily
confusing. Also make the codec parameters optional.

BUG=None
==========

to

==========
Make a friendlier RTCVideoCodecInfo initializer for when only name and
parameters are interesting.

Since this is used by users when implementing injectable Obj-C video
codecs, the API where the unused payload is required is unnecessarily
confusing. Also make the codec parameters optional.

BUG=None

Review-Url: https://codereview.webrtc.org/3001183002
Cr-Commit-Position: refs/heads/master@{#19411}
Committed:
https://chromium.googlesource.com/external/webrtc/+/81bc523f5d7eab43796373954...
==========

[commit-bot: I haz the power, 2017-08-18 13:34:20]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/81bc523f5d7eab43796373954...