Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h

Issue 3001183002: Make a friendlier RTCVideoCodecInfo initializer. (Closed)
Patch Set: Mark -init as unavailable. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 93
94 typedef NS_ENUM(NSUInteger, RTCVideoCodecMode) { 94 typedef NS_ENUM(NSUInteger, RTCVideoCodecMode) {
95 RTCVideoCodecModeRealtimeVideo, 95 RTCVideoCodecModeRealtimeVideo,
96 RTCVideoCodecModeScreensharing, 96 RTCVideoCodecModeScreensharing,
97 }; 97 };
98 98
99 /** Holds information to identify a codec. Corresponds to cricket::VideoCodec. * / 99 /** Holds information to identify a codec. Corresponds to cricket::VideoCodec. * /
100 RTC_EXPORT 100 RTC_EXPORT
101 @interface RTCVideoCodecInfo : NSObject 101 @interface RTCVideoCodecInfo : NSObject
102 102
103 - (instancetype)init NS_UNAVAILABLE;
104
103 - (instancetype)initWithPayload:(NSInteger)payload 105 - (instancetype)initWithPayload:(NSInteger)payload
104 name:(NSString *)name 106 name:(NSString *)name
105 parameters:(NSDictionary<NSString *, NSString *> *)paramete rs; 107 parameters:(NSDictionary<NSString *, NSString *> *)paramete rs
kthelgason 2017/08/18 12:25:44 Are we ever expecting this to be called for any re
andersc 2017/08/18 13:30:37 You're right, this is only used internally. Moving
108 NS_DESIGNATED_INITIALIZER;
109
110 - (instancetype)initWithName:(NSString *)name
111 parameters:(nullable NSDictionary<NSString *, NSString *> *)pa rameters;
106 112
107 @property(nonatomic, readonly) NSInteger payload; 113 @property(nonatomic, readonly) NSInteger payload;
108 @property(nonatomic, readonly) NSString *name; 114 @property(nonatomic, readonly) NSString *name;
109 @property(nonatomic, readonly) NSDictionary<NSString *, NSString *> *parameters; 115 @property(nonatomic, readonly) NSDictionary<NSString *, NSString *> *parameters;
110 116
111 @end 117 @end
112 118
113 /** Settings for encoder. Corresponds to webrtc::VideoCodec. */ 119 /** Settings for encoder. Corresponds to webrtc::VideoCodec. */
114 RTC_EXPORT 120 RTC_EXPORT
115 @interface RTCVideoEncoderSettings : NSObject 121 @interface RTCVideoEncoderSettings : NSObject
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 - (NSInteger)decode:(RTCEncodedImage *)encodedImage 180 - (NSInteger)decode:(RTCEncodedImage *)encodedImage
175 missingFrames:(BOOL)missingFrames 181 missingFrames:(BOOL)missingFrames
176 fragmentationHeader:(RTCRtpFragmentationHeader *)fragmentationHeader 182 fragmentationHeader:(RTCRtpFragmentationHeader *)fragmentationHeader
177 codecSpecificInfo:(__nullable id<RTCCodecSpecificInfo>)info 183 codecSpecificInfo:(__nullable id<RTCCodecSpecificInfo>)info
178 renderTimeMs:(int64_t)renderTimeMs; 184 renderTimeMs:(int64_t)renderTimeMs;
179 - (NSString *)implementationName; 185 - (NSString *)implementationName;
180 186
181 @end 187 @end
182 188
183 NS_ASSUME_NONNULL_END 189 NS_ASSUME_NONNULL_END
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698