Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 3000943002: Reland of Trace the stats report as JSON instead of each stat separately. (Closed)

Created:
3 years, 4 months ago by ehmaldonado_webrtc
Modified:
3 years, 3 months ago
Reviewers:
tommi, hbos, mbonadei
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Trace the stats report as JSON instead of each stat separately. (patchset #1 id:1 of https://codereview.webrtc.org/3001683002/ ) Reason for revert: Fixed Original issue's description: > Revert of Trace the stats report as JSON instead of each stat separately. (patchset #3 id:100001 of https://codereview.webrtc.org/2986453002/ ) > > Reason for revert: > It breaks a downstream project. > > Original issue's description: > > Trace the stats report as JSON instead of each stat separately. > > > > Trace the whole report as a string instead of each field on it's own. And test that the traces collected are valid. > > > > R=tommi@webrtc.org, hbos@webrtc.org > > BUG=chromium:653087 > > > > Review-Url: https://codereview.webrtc.org/2986453002 > > Cr-Commit-Position: refs/heads/master@{#19341} > > Committed: https://chromium.googlesource.com/external/webrtc/+/80c65780e618f90369295fe5daf8075e9b374c26 > > TBR=hbos@webrtc.org,tommi@webrtc.org,ehmaldonado@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:653087 > > Review-Url: https://codereview.webrtc.org/3001683002 > Cr-Commit-Position: refs/heads/master@{#19344} > Committed: https://chromium.googlesource.com/external/webrtc/+/3439c893585e0958502ef397056a372be1777688 BUG=chromium:653087 Review-Url: https://codereview.webrtc.org/3000943002 Cr-Commit-Position: refs/heads/master@{#19673} Committed: https://chromium.googlesource.com/external/webrtc/+/8ab0fd80ad4af302d8f72e94e577458084772288

Patch Set 1 : Original CL #

Patch Set 2 : This should work. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -35 lines) Patch
M webrtc/pc/rtcstats_integrationtest.cc View 1 5 chunks +52 lines, -13 lines 0 comments Download
M webrtc/pc/rtcstatscollector.cc View 1 2 chunks +2 lines, -22 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
ehmaldonado_webrtc
Created Reland of Trace the stats report as JSON instead of each stat separately.
3 years, 4 months ago (2017-08-15 10:41:22 UTC) #1
tommi
lgtm
3 years, 4 months ago (2017-08-15 13:47:06 UTC) #3
ehmaldonado_webrtc
On 2017/08/15 13:47:06, tommi (ooo) wrote: > lgtm (Haven't changed anything yet, sorry :)
3 years, 4 months ago (2017-08-15 13:51:20 UTC) #4
tommi
On 2017/08/15 13:51:20, ehmaldonado_webrtc wrote: > On 2017/08/15 13:47:06, tommi (ooo) wrote: > > lgtm ...
3 years, 4 months ago (2017-08-15 13:54:15 UTC) #5
ehmaldonado_webrtc
On 2017/08/15 13:54:15, tommi wrote: > On 2017/08/15 13:51:20, ehmaldonado_webrtc wrote: > > On 2017/08/15 ...
3 years, 3 months ago (2017-09-04 18:00:57 UTC) #16
ehmaldonado_webrtc
On 2017/09/04 18:00:57, ehmaldonado_webrtc wrote: > On 2017/08/15 13:54:15, tommi wrote: > > On 2017/08/15 ...
3 years, 3 months ago (2017-09-04 20:19:16 UTC) #17
tommi
lgtm
3 years, 3 months ago (2017-09-04 21:04:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3000943002/110001
3 years, 3 months ago (2017-09-04 21:33:01 UTC) #20
commit-bot: I haz the power
3 years, 3 months ago (2017-09-04 21:35:11 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:110001) as
https://chromium.googlesource.com/external/webrtc/+/8ab0fd80ad4af302d8f72e94e...

Powered by Google App Engine
This is Rietveld 408576698