Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 3001683002: Revert of Trace the stats report as JSON instead of each stat separately. (Closed)

Created:
3 years, 4 months ago by mbonadei
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Trace the stats report as JSON instead of each stat separately. (patchset #3 id:100001 of https://codereview.webrtc.org/2986453002/ ) Reason for revert: It breaks a downstream project. Original issue's description: > Trace the stats report as JSON instead of each stat separately. > > Trace the whole report as a string instead of each field on it's own. And test that the traces collected are valid. > > R=tommi@webrtc.org, hbos@webrtc.org > BUG=chromium:653087 > > Review-Url: https://codereview.webrtc.org/2986453002 > Cr-Commit-Position: refs/heads/master@{#19341} > Committed: https://chromium.googlesource.com/external/webrtc/+/80c65780e618f90369295fe5daf8075e9b374c26 TBR=hbos@webrtc.org,tommi@webrtc.org,ehmaldonado@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:653087 Review-Url: https://codereview.webrtc.org/3001683002 Cr-Commit-Position: refs/heads/master@{#19344} Committed: https://chromium.googlesource.com/external/webrtc/+/3439c893585e0958502ef397056a372be1777688

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -55 lines) Patch
M webrtc/pc/rtcstats_integrationtest.cc View 5 chunks +13 lines, -53 lines 0 comments Download
M webrtc/pc/rtcstatscollector.cc View 2 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mbonadei
Created Revert of Trace the stats report as JSON instead of each stat separately.
3 years, 4 months ago (2017-08-15 06:47:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3001683002/1
3 years, 4 months ago (2017-08-15 06:47:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/3439c893585e0958502ef397056a372be1777688
3 years, 4 months ago (2017-08-15 06:48:12 UTC) #6
ehmaldonado_webrtc
3 years, 4 months ago (2017-08-15 10:41:22 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/3000943002/ by ehmaldonado@webrtc.org.

The reason for reverting is: Fixed.

Powered by Google App Engine
This is Rietveld 408576698