Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 3000613002: Reorganize code in plot_videoprocessor_integrationtest.cc. (Closed)

Created:
3 years, 4 months ago by brandtr
Modified:
3 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reorganize code in plot_videoprocessor_integrationtest.cc. * Don't loop over fps, but do loop over codec implementation type. * Order codec settings as they are defined in the test. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/3000613002 Cr-Commit-Position: refs/heads/master@{#19330} Committed: https://chromium.googlesource.com/external/webrtc/+/ef8eb8c10da383c386f8f9e64e13864b4151450f

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -36 lines) Patch
M webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 2 chunks +37 lines, -36 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
brandtr
Please take a look :)
3 years, 4 months ago (2017-08-09 11:08:12 UTC) #2
brandtr
Rebase.
3 years, 4 months ago (2017-08-09 11:20:04 UTC) #3
åsapersson
lgtm
3 years, 4 months ago (2017-08-09 13:59:57 UTC) #4
brandtr
Rebase.
3 years, 4 months ago (2017-08-14 06:50:20 UTC) #5
brandtr
Rebase.
3 years, 4 months ago (2017-08-14 06:51:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3000613002/60001
3 years, 4 months ago (2017-08-14 06:55:29 UTC) #9
commit-bot: I haz the power
3 years, 4 months ago (2017-08-14 08:06:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/ef8eb8c10da383c386f8f9e64...

Powered by Google App Engine
This is Rietveld 408576698