Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2999643002: Rename SetProcessParams -> SetTestConfig. (Closed)

Created:
3 years, 4 months ago by brandtr
Modified:
3 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename SetProcessParams -> SetTestConfig. Also remove |key_frame_interval| from argument list, since it is always set to -1. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2999643002 Cr-Commit-Position: refs/heads/master@{#19331} Committed: https://chromium.googlesource.com/external/webrtc/+/deac84107f3ef8932d8f979b963fe559670c3648

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -57 lines) Patch
M webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 2 2 chunks +21 lines, -24 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 1 2 15 chunks +29 lines, -30 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (11 generated)
brandtr
PTAL https://codereview.webrtc.org/2999643002/diff/40001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h (right): https://codereview.webrtc.org/2999643002/diff/40001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h#newcode584 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:584: config->networking_config.packet_loss_probability = packet_loss_probability; Reordered to match definitions in ...
3 years, 4 months ago (2017-08-09 10:55:31 UTC) #4
brandtr
Rebase.
3 years, 4 months ago (2017-08-09 11:20:17 UTC) #5
åsapersson
lgtm
3 years, 4 months ago (2017-08-09 13:48:19 UTC) #6
brandtr
Rebase.
3 years, 4 months ago (2017-08-14 06:56:31 UTC) #7
brandtr
Rebase.
3 years, 4 months ago (2017-08-14 06:58:30 UTC) #8
brandtr
Rebase.
3 years, 4 months ago (2017-08-14 06:59:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2999643002/120001
3 years, 4 months ago (2017-08-14 08:13:46 UTC) #16
commit-bot: I haz the power
3 years, 4 months ago (2017-08-14 08:29:24 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/deac84107f3ef8932d8f979b9...

Powered by Google App Engine
This is Rietveld 408576698