Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2999893002: Revert of Make the acceptable queue in the cwnd experiment configurable. (Closed)

Created:
3 years, 4 months ago by stefan-webrtc
Modified:
3 years, 4 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Make the acceptable queue in the cwnd experiment configurable. (patchset #1 id:1 of https://codereview.webrtc.org/2998753002/ ) Reason for revert: Speculative revert to see if this caused regressions in android perf tests. Original issue's description: > Make the acceptable queue in the cwnd experiment configurable. > > BUG=webrtc:7926 > > Review-Url: https://codereview.webrtc.org/2998753002 > Cr-Commit-Position: refs/heads/master@{#19320} > Committed: https://chromium.googlesource.com/external/webrtc/+/7c83c56b6dc521d82285798c2d0e7eec205ed3f0 TBR=philipel@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7926 Review-Url: https://codereview.webrtc.org/2999893002 Cr-Commit-Position: refs/heads/master@{#19337} Committed: https://chromium.googlesource.com/external/webrtc/+/c5d9e63c2bed77422c365c46086f215680c0aa73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -27 lines) Patch
M webrtc/modules/congestion_controller/include/send_side_congestion_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/send_side_congestion_controller.cc View 4 chunks +2 lines, -24 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
stefan-webrtc
Created Revert of Make the acceptable queue in the cwnd experiment configurable.
3 years, 4 months ago (2017-08-14 11:55:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2999893002/1
3 years, 4 months ago (2017-08-14 11:56:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/c5d9e63c2bed77422c365c46086f215680c0aa73
3 years, 4 months ago (2017-08-14 12:55:08 UTC) #6
stefan-webrtc
3 years, 4 months ago (2017-08-16 17:33:18 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2999083002/ by stefan@webrtc.org.

The reason for reverting is: Reland.

Powered by Google App Engine
This is Rietveld 408576698