Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2998753002: Make the acceptable queue in the cwnd experiment configurable. (Closed)

Created:
3 years, 4 months ago by stefan-webrtc
Modified:
3 years, 4 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make the acceptable queue in the cwnd experiment configurable. BUG=webrtc:7926 Review-Url: https://codereview.webrtc.org/2998753002 Cr-Commit-Position: refs/heads/master@{#19320} Committed: https://chromium.googlesource.com/external/webrtc/+/7c83c56b6dc521d82285798c2d0e7eec205ed3f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M webrtc/modules/congestion_controller/include/send_side_congestion_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/send_side_congestion_controller.cc View 5 chunks +24 lines, -2 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
stefan-webrtc
3 years, 4 months ago (2017-08-10 08:23:08 UTC) #2
philipel
lgtm
3 years, 4 months ago (2017-08-10 14:27:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2998753002/1
3 years, 4 months ago (2017-08-10 14:28:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/builds/25628) android_rel on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 4 months ago (2017-08-10 14:31:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2998753002/1
3 years, 4 months ago (2017-08-11 07:40:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/7c83c56b6dc521d82285798c2d0e7eec205ed3f0
3 years, 4 months ago (2017-08-11 08:24:03 UTC) #12
stefan-webrtc
3 years, 4 months ago (2017-08-14 11:55:57 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2999893002/ by stefan@webrtc.org.

The reason for reverting is: Speculative revert to see if this caused
regressions in android perf tests..

Powered by Google App Engine
This is Rietveld 408576698