Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 2997963002: Revert of Make it possible for tests to set up trace event handlers. (Closed)

Created:
3 years, 4 months ago by ehmaldonado_webrtc
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Make it possible for tests to set up trace event handlers. (patchset #4 id:60001 of https://codereview.webrtc.org/3002663002/ ) Reason for revert: Breaks Chromium bots. https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/27340/steps/generate_build_files/logs/stdio Original issue's description: > Make it possible for tests to set up trace event handlers. > > As it is now, the first time a TRACE_EVENT... is called, the result from > the current handler is stored in a static const variable, and subsequent > calls will use that value regardless of changes to the handler. > > This is a problem if a test wants to use another handler. > > BUG=None > > Review-Url: https://codereview.webrtc.org/3002663002 > Cr-Commit-Position: refs/heads/master@{#19382} > Committed: https://chromium.googlesource.com/external/webrtc/+/a9732656221e0033ab93ecf01cf07f71817da1e8 TBR=hbos@webrtc.org,kwiberg@webrtc.org,mbonadei@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2997963002 Cr-Commit-Position: refs/heads/master@{#19383} Committed: https://chromium.googlesource.com/external/webrtc/+/db758c2589a983a7dd94dfdd9272892e28251fe4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/rtc_base/trace_event.h View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ehmaldonado_webrtc
Created Revert of Make it possible for tests to set up trace event handlers.
3 years, 4 months ago (2017-08-17 13:06:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997963002/1
3 years, 4 months ago (2017-08-17 13:06:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/db758c2589a983a7dd94dfdd9272892e28251fe4
3 years, 4 months ago (2017-08-17 13:07:09 UTC) #6
ehmaldonado_webrtc
3 years, 4 months ago (2017-08-17 13:56:11 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2995123002/ by ehmaldonado@webrtc.org.

The reason for reverting is: This should fix it.

Powered by Google App Engine
This is Rietveld 408576698