Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2995123002: Reland of Make it possible for tests to set up trace event handlers. (Closed)

Created:
3 years, 4 months ago by ehmaldonado_webrtc
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Make it possible for tests to set up trace event handlers. (patchset #1 id:1 of https://codereview.webrtc.org/2997963002/ ) Reason for revert: This should fix it Original issue's description: > Revert of Make it possible for tests to set up trace event handlers. (patchset #4 id:60001 of https://codereview.webrtc.org/3002663002/ ) > > Reason for revert: > Breaks Chromium bots. > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/27340/steps/generate_build_files/logs/stdio > > Original issue's description: > > Make it possible for tests to set up trace event handlers. > > > > As it is now, the first time a TRACE_EVENT... is called, the result from > > the current handler is stored in a static const variable, and subsequent > > calls will use that value regardless of changes to the handler. > > > > This is a problem if a test wants to use another handler. > > > > BUG=None > > > > Review-Url: https://codereview.webrtc.org/3002663002 > > Cr-Commit-Position: refs/heads/master@{#19382} > > Committed: https://chromium.googlesource.com/external/webrtc/+/a9732656221e0033ab93ecf01cf07f71817da1e8 > > TBR=hbos@webrtc.org,kwiberg@webrtc.org,mbonadei@webrtc.org,kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=None > > Review-Url: https://codereview.webrtc.org/2997963002 > Cr-Commit-Position: refs/heads/master@{#19383} > Committed: https://chromium.googlesource.com/external/webrtc/+/db758c2589a983a7dd94dfdd9272892e28251fe4 TBR=hbos@webrtc.org,kwiberg@webrtc.org,mbonadei@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2995123002 Cr-Commit-Position: refs/heads/master@{#19386} Committed: https://chromium.googlesource.com/external/webrtc/+/481c549b29bab2e5314204884a117c9669846111

Patch Set 1 : Original CL #

Patch Set 2 : Fix issue #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M webrtc/BUILD.gn View 1 1 chunk +12 lines, -1 line 3 comments Download
M webrtc/rtc_base/trace_event.h View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
ehmaldonado_webrtc
Created Reland of Make it possible for tests to set up trace event handlers.
3 years, 4 months ago (2017-08-17 13:56:11 UTC) #1
mbonadei
https://codereview.webrtc.org/2995123002/diff/70001/webrtc/BUILD.gn File webrtc/BUILD.gn (right): https://codereview.webrtc.org/2995123002/diff/70001/webrtc/BUILD.gn#newcode41 webrtc/BUILD.gn:41: defines += [ Oh... This was a well hidden ...
3 years, 4 months ago (2017-08-17 14:02:50 UTC) #2
mbonadei
lgtm is the bot is green.
3 years, 4 months ago (2017-08-17 14:03:13 UTC) #3
ehmaldonado_webrtc
https://codereview.webrtc.org/2995123002/diff/70001/webrtc/BUILD.gn File webrtc/BUILD.gn (right): https://codereview.webrtc.org/2995123002/diff/70001/webrtc/BUILD.gn#newcode41 webrtc/BUILD.gn:41: defines += [ On 2017/08/17 14:02:50, mbonadei wrote: > ...
3 years, 4 months ago (2017-08-17 14:05:13 UTC) #4
mbonadei
https://codereview.webrtc.org/2995123002/diff/70001/webrtc/BUILD.gn File webrtc/BUILD.gn (right): https://codereview.webrtc.org/2995123002/diff/70001/webrtc/BUILD.gn#newcode41 webrtc/BUILD.gn:41: defines += [ On 2017/08/17 14:05:13, ehmaldonado_webrtc wrote: > ...
3 years, 4 months ago (2017-08-17 14:08:34 UTC) #5
kwiberg-webrtc
lgtm
3 years, 4 months ago (2017-08-17 14:11:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2995123002/70001
3 years, 4 months ago (2017-08-17 14:59:48 UTC) #8
commit-bot: I haz the power
3 years, 4 months ago (2017-08-17 15:00:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:70001) as
https://chromium.googlesource.com/external/webrtc/+/481c549b29bab2e5314204884...

Powered by Google App Engine
This is Rietveld 408576698