Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2997883002: Video/Screenshare loopback tool.

Created:
3 years, 4 months ago by philipel
Modified:
3 years, 2 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Video/Screenshare loopback tool. Useful commands: ninja -C out/Debug/ vs_loopback event_log_visualizer ./vs_loopback --link_capacity 500 --max_bitrate 10000 --force_fieldtrials="WebRTC-ProbingScreenshareBwe/1.1,3000,80,30,-80/" --loss_percent 2 --avg_propagation_delay_ms 50 2> /dev/null ~/webrtc-checkout/src/out/Debug/event_log_visualizer --show_detector_state --plot_profile none --plot_outgoingitrate --plot_outgoing_stream_bitrate --plot_network_delay_feedback $(ls -t | head -n 1) | python BUG=None

Patch Set 1 #

Patch Set 2 : Proper tear-down. #

Patch Set 3 : Now log to RtcEventLog #

Patch Set 4 : Separate send/receive rtc event logs and start logging in the ctor instead of the dtor -_- #

Patch Set 5 : Rebase + log overuse detector state + enable ALR probing #

Patch Set 6 : Log acked bitrate/alr state to rtc event log. #

Patch Set 7 : Bandwidth usage is no longer inverted #

Patch Set 8 : Stuff #

Patch Set 9 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1570 lines, -904 lines) Patch
M webrtc/call/call.h View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/call/call.cc View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -0 lines 0 comments Download
M webrtc/common_types.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 1 2 3 4 5 6 7 2 chunks +8 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 2 3 4 5 6 7 2 chunks +35 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.proto View 1 2 3 4 5 6 7 3 chunks +33 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.h View 1 2 3 4 5 6 7 8 3 chunks +27 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 1 2 3 4 5 6 7 2 chunks +57 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.h View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.cc View 1 2 3 4 5 3 chunks +11 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 1 2 3 4 5 6 7 2 chunks +7 lines, -5 lines 0 comments Download
M webrtc/modules/congestion_controller/include/send_side_congestion_controller.h View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_bitrate_estimator.h View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/probe_bitrate_estimator.cc View 1 2 3 4 5 6 7 8 6 chunks +61 lines, -16 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_controller.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_controller.cc View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/send_side_congestion_controller.cc View 1 2 3 4 5 6 7 8 4 chunks +29 lines, -3 lines 0 comments Download
M webrtc/modules/pacing/alr_detector.h View 1 2 3 4 5 3 chunks +4 lines, -0 lines 0 comments Download
M webrtc/modules/pacing/alr_detector.cc View 1 2 3 4 5 6 4 chunks +12 lines, -3 lines 0 comments Download
M webrtc/modules/pacing/bitrate_prober.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -1 line 0 comments Download
M webrtc/modules/pacing/interval_budget.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 1 2 3 4 5 6 7 8 chunks +12 lines, -6 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/send_time_history.cc View 1 2 3 4 5 6 7 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/rtc_tools/event_log_visualizer/analyzer.h View 1 2 3 4 5 6 7 2 chunks +8 lines, -0 lines 0 comments Download
M webrtc/rtc_tools/event_log_visualizer/analyzer.cc View 1 2 3 4 5 6 7 8 4 chunks +72 lines, -0 lines 0 comments Download
M webrtc/rtc_tools/event_log_visualizer/main.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/rtc_tools/event_log_visualizer/plot_python.cc View 1 2 3 4 5 2 chunks +16 lines, -7 lines 0 comments Download
M webrtc/system_wrappers/include/clock.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/system_wrappers/source/clock.cc View 1 2 3 4 5 1 chunk +22 lines, -0 lines 0 comments Download
M webrtc/test/call_test.h View 1 2 3 4 5 6 7 8 2 chunks +16 lines, -3 lines 0 comments Download
M webrtc/test/call_test.cc View 1 2 3 4 5 6 7 8 7 chunks +175 lines, -188 lines 0 comments Download
M webrtc/test/fake_network_pipe.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/test/fake_network_pipe.cc View 1 2 3 4 5 6 7 8 1 chunk +8 lines, -2 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +24 lines, -0 lines 0 comments Download
M webrtc/video/video_quality_test.h View 4 chunks +32 lines, -9 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 2 3 4 5 6 7 8 8 chunks +479 lines, -655 lines 0 comments Download
A webrtc/video/vs_loopback.cc View 1 chunk +340 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 3 4 5 6 7 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
philipel
Description was changed from ========== Video/Screenshare loopback tool. BUG=None ========== to ========== Video/Screenshare loopback tool. ...
3 years, 4 months ago (2017-08-16 14:38:19 UTC) #1
philipel
Description was changed from ========== Video/Screenshare loopback tool. To build: ninja -C out/Debug vs_loopback Nothing ...
3 years, 4 months ago (2017-08-23 09:15:23 UTC) #2
philipel
3 years, 4 months ago (2017-08-23 09:40:37 UTC) #3
Description was changed from

==========
Video/Screenshare loopback tool.

Useful commands:
ninja -C out/Debug/ vs_loopback event_log_visualizer

./vs_loopback --link_capacity 500 --max_bitrate 10000
--force_fieldtrials="WebRTC-ProbingScreenshareBwe/1.1,3000,80,30,-80/"
--loss_percent 2 --avg_propagation_delay_ms 50 2> /dev/null

BUG=None
==========

to

==========
Video/Screenshare loopback tool.

Useful commands:
  ninja -C out/Debug/ vs_loopback event_log_visualizer
  ./vs_loopback --link_capacity 500 --max_bitrate 10000
--force_fieldtrials="WebRTC-ProbingScreenshareBwe/1.1,3000,80,30,-80/"
--loss_percent 2 --avg_propagation_delay_ms 50 2> /dev/null
  ~/webrtc-checkout/src/out/Debug/event_log_visualizer --show_detector_state
--plot_profile none --plot_outgoingitrate --plot_outgoing_stream_bitrate
--plot_network_delay_feedback $(ls -t | head -n 1) | python

BUG=None
==========

Powered by Google App Engine
This is Rietveld 408576698