Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: webrtc/modules/congestion_controller/delay_based_bwe.cc

Issue 2997883002: Video/Screenshare loopback tool.
Patch Set: Rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/delay_based_bwe.cc
diff --git a/webrtc/modules/congestion_controller/delay_based_bwe.cc b/webrtc/modules/congestion_controller/delay_based_bwe.cc
index dd59b8a81bea71507294182edfbbdc1ffe4d68e3..139b40fb04a0c5a52da807942fa864b18e450cec 100644
--- a/webrtc/modules/congestion_controller/delay_based_bwe.cc
+++ b/webrtc/modules/congestion_controller/delay_based_bwe.cc
@@ -217,7 +217,7 @@ DelayBasedBwe::Result DelayBasedBwe::MaybeUpdateEstimate(
int64_t now_ms = clock_->TimeInMilliseconds();
rtc::Optional<int> probe_bitrate_bps =
- probe_bitrate_estimator_.FetchAndResetLastEstimatedBitrateBps();
+ probe_bitrate_estimator_.FetchAndResetLastEstimatedBitrateBps(50);
// Currently overusing the bandwidth.
if (overusing) {
if (acked_bitrate_bps &&
@@ -249,14 +249,16 @@ DelayBasedBwe::Result DelayBasedBwe::MaybeUpdateEstimate(
result.recovered_from_overuse = recovered_from_overuse;
}
}
- if (result.updated) {
+ if (result.updated || detector_.State() != last_logged_state_) {
BWE_TEST_LOGGING_PLOT(1, "target_bitrate_bps", now_ms,
result.target_bitrate_bps);
if (event_log_ && (result.target_bitrate_bps != last_logged_bitrate_ ||
detector_.State() != last_logged_state_)) {
- event_log_->LogDelayBasedBweUpdate(result.target_bitrate_bps,
- detector_.State());
- last_logged_bitrate_ = result.target_bitrate_bps;
+ uint32_t bitrate_bps =
+ result.updated ? result.target_bitrate_bps : last_logged_bitrate_;
+ event_log_->LogDelayBasedBweUpdate(bitrate_bps, detector_.State());
+ if (result.target_bitrate_bps > 0)
+ last_logged_bitrate_ = result.target_bitrate_bps;
last_logged_state_ = detector_.State();
}
}

Powered by Google App Engine
This is Rietveld 408576698