Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2997523002: Reland of move linux_internal from the autoroller CQ. (Closed)

Created:
3 years, 4 months ago by ehmaldonado_webrtc
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of move linux_internal from the autoroller CQ. (patchset #1 id:1 of https://codereview.webrtc.org/2990233002/ ) Reason for revert: linux_internal buildbucket is broken Original issue's description: > Revert of Remove linux_internal from the autoroller CQ. (patchset #1 id:1 of https://codereview.webrtc.org/2985933002/ ) > > Reason for revert: > linux_internal now checks that the CL is authored by a googler before executing the tests > > Original issue's description: > > Remove linux_internal from the autoroller CQ. > > > > The CQ no longer has permission to schedule builds in linux_internal. > > > > NOTRY=True > > TBR=kjellander@webrtc.org > > BUG=None > > > > Review-Url: https://codereview.webrtc.org/2985933002 > > Cr-Commit-Position: refs/heads/master@{#19178} > > Committed: https://chromium.googlesource.com/external/webrtc/+/5ba9730265c3bb4069fdda557805d594b1cff789 > > TBR=mbonadei@webrtc.org,kjellander@webrtc.org,nodir@chromium.org > BUG=None > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2990233002 > Cr-Commit-Position: refs/heads/master@{#19240} > Committed: https://chromium.googlesource.com/external/webrtc/+/367aaa7ca5eeac7ca18ace3fce16636a8dccf0ff TBR=mbonadei@webrtc.org,kjellander@webrtc.org,nodir@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=None Review-Url: https://codereview.webrtc.org/2997523002 Cr-Commit-Position: refs/heads/master@{#19260} Committed: https://chromium.googlesource.com/external/webrtc/+/81cf5bbff959f4a4ccb27fe3b48a7292b54f0734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tools_webrtc/autoroller/roll_deps.py View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ehmaldonado_webrtc
Created Reland of move linux_internal from the autoroller CQ.
3 years, 4 months ago (2017-08-07 17:59:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997523002/1
3 years, 4 months ago (2017-08-07 17:59:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/81cf5bbff959f4a4ccb27fe3b48a7292b54f0734
3 years, 4 months ago (2017-08-07 18:39:24 UTC) #6
ehmaldonado_webrtc
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/3001523002/ by ehmaldonado@webrtc.org. ...
3 years, 4 months ago (2017-08-10 20:48:42 UTC) #7
nodir1
3 years, 4 months ago (2017-08-10 21:51:04 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698