Remove linux_internal from the autoroller CQ.

Remove linux_internal from the autoroller CQ.

The CQ no longer has permission to schedule builds in linux_internal.

NOTRY=True
TBR=kjellander@webrtc.org
BUG=None

Review-Url: https://codereview.webrtc.org/2985933002
Cr-Commit-Position: refs/heads/master@{#19178}
Committed: https://chromium.googlesource.com/external/webrtc/+/5ba9730265c3bb4069fdda557805d594b1cff789

[ehmaldonado_webrtc, 2017-07-26 18:41:19]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org, mbonadei@webrtc.org

[kjellander_webrtc, 2017-07-26 20:03:57]

kjellander@webrtc.org changed reviewers:
+ nodir@chromium.org

[kjellander_webrtc, 2017-07-26 20:03:58]

nodir: this must be because of https://codereview.webrtc.org/2987913002/, right?


We definitely need this bot to be able to run if specified like this. Is there
another way to accomplish that?

[ehmaldonado_webrtc, 2017-07-26 20:07:43]

On 2017/07/26 20:03:58, kjellander_rtc OOO Jul3-Aug11 wrote:
> nodir: this must be because of https://codereview.webrtc.org/2987913002/,
right?
> 
> 
> We definitely need this bot to be able to run if specified like this. Is there
> another way to accomplish that?

We could run in the recipe:
git cl try ...

We wouldn't send the CL to CQ (only dry run), since CQ would ignore the result
of linux_internal.
My idea would be then to schedule the build more frequently (~30 min) and:
1. If there is a CL with pending try jobs: do nothing.
2. If there is a CL with finished try jobs: commit if all of the succeed.
3. If there is no CL: Make a CL, upload it to Rietveld, trigger a dry run and
the linux_internal bot.

[kjellander_webrtc, 2017-07-26 20:26:12]

On 2017/07/26 20:07:43, ehmaldonado_webrtc wrote:
> On 2017/07/26 20:03:58, kjellander_rtc OOO Jul3-Aug11 wrote:
> > nodir: this must be because of https://codereview.webrtc.org/2987913002/,
> right?
> > 
> > 
> > We definitely need this bot to be able to run if specified like this. Is
there
> > another way to accomplish that?
> 
> We could run in the recipe:
> git cl try ...
> 
> We wouldn't send the CL to CQ (only dry run), since CQ would ignore the result
> of linux_internal.
> My idea would be then to schedule the build more frequently (~30 min) and:
> 1. If there is a CL with pending try jobs: do nothing.
> 2. If there is a CL with finished try jobs: commit if all of the succeed.
> 3. If there is no CL: Make a CL, upload it to Rietveld, trigger a dry run and
> the linux_internal bot.

I'd prefer to use a supported feature rather than hacks. I hope nodir@ can tell
us what the best approach is.
Otherwise we could explore something like that as a last resort.

[ehmaldonado_webrtc, 2017-07-28 12:59:08]

Description was changed from

==========
Remove linux_internal from the autoroller CQ.

The CQ no longer has permission to schedule builds in linux_internal.

BUG=
==========

to

==========
Remove linux_internal from the autoroller CQ.

The CQ no longer has permission to schedule builds in linux_internal.

NOTRY=True
==========

[ehmaldonado_webrtc, 2017-07-28 12:59:09]

Description was changed from

==========
Remove linux_internal from the autoroller CQ.

The CQ no longer has permission to schedule builds in linux_internal.

BUG=
==========

to

==========
Remove linux_internal from the autoroller CQ.

The CQ no longer has permission to schedule builds in linux_internal.

NOTRY=True
==========

[ehmaldonado_webrtc, 2017-07-28 12:59:16]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2017-07-28 12:59:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-28 12:59:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-28 12:59:20]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

[ehmaldonado_webrtc, 2017-07-28 13:17:11]

Description was changed from

==========
Remove linux_internal from the autoroller CQ.

The CQ no longer has permission to schedule builds in linux_internal.

NOTRY=True
==========

to

==========
Remove linux_internal from the autoroller CQ.

The CQ no longer has permission to schedule builds in linux_internal.

NOTRY=True
TBR=kjellander@webrtc.org
==========

[ehmaldonado_webrtc, 2017-07-28 13:17:21]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2017-07-28 13:17:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-28 13:23:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-28 13:23:19]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19686)

[ehmaldonado_webrtc, 2017-07-28 13:23:32]

Description was changed from

==========
Remove linux_internal from the autoroller CQ.

The CQ no longer has permission to schedule builds in linux_internal.

NOTRY=True
TBR=kjellander@webrtc.org
==========

to

==========
Remove linux_internal from the autoroller CQ.

The CQ no longer has permission to schedule builds in linux_internal.

NOTRY=True
TBR=kjellander@webrtc.org
BUG=None
==========

[ehmaldonado_webrtc, 2017-07-28 13:23:43]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2017-07-28 13:23:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-28 13:27:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1501248223606070, "parent_rev":
"54348fb5ce8ce606eb370cb7c4e36b7e3caec28e", "commit_rev":
"5ba9730265c3bb4069fdda557805d594b1cff789"}

[commit-bot: I haz the power, 2017-07-28 13:27:07]

Description was changed from

==========
Remove linux_internal from the autoroller CQ.

The CQ no longer has permission to schedule builds in linux_internal.

NOTRY=True
TBR=kjellander@webrtc.org
BUG=None
==========

to

==========
Remove linux_internal from the autoroller CQ.

The CQ no longer has permission to schedule builds in linux_internal.

NOTRY=True
TBR=kjellander@webrtc.org
BUG=None

Review-Url: https://codereview.webrtc.org/2985933002
Cr-Commit-Position: refs/heads/master@{#19178}
Committed:
https://chromium.googlesource.com/external/webrtc/+/5ba9730265c3bb4069fdda557...
==========

[commit-bot: I haz the power, 2017-07-28 13:27:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5ba9730265c3bb4069fdda557...

[ehmaldonado_webrtc, 2017-08-03 16:09:01]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2990233002/ by ehmaldonado@webrtc.org.

The reason for reverting is: linux_internal now checks that the CL is authored
by a googler before executing the tests.