Give Audio{De,En}coderIsac* an "Impl" suffix, to free up the original names

Give Audio{De,En}coderIsac* an "Impl" suffix, to free up the original names

I want to publish an API for iSAC in webrtc/api/, and I want to use
the class names Audio{De,En}coderIsac{Fix,Float}.

BUG=webrtc:7835, webrtc:7841
Review-Url: https://codereview.webrtc.org/2996593002
Cr-Commit-Position: refs/heads/master@{#19381}
Committed: https://chromium.googlesource.com/external/webrtc/+/6ff045f097529ab71fbe9233a712c4bdce3f440d

[kwiberg-webrtc, 2017-08-07 09:17:31]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-07 09:17:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-07 09:47:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-07 09:47:51]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-08-07 10:44:36]

kwiberg@webrtc.org changed reviewers:
+ ossu@webrtc.org

[kwiberg-webrtc, 2017-08-10 12:38:41]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-10 12:38:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-10 13:51:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-10 13:51:51]

Dry run: Try jobs failed on following builders:
  android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg...)

[ossu, 2017-08-15 13:47:15]

Maybe it's possible to get around this by just removing the aliases for the
Float and Fix variants instead. At this point, their aliases' names are almost
as long as the full template-and-typename. WDYT?

[kwiberg-webrtc, 2017-08-16 11:48:58]

On 2017/08/15 13:47:15, ossu wrote:
> Maybe it's possible to get around this by just removing the aliases for the
> Float and Fix variants instead. At this point, their aliases' names are almost
> as long as the full template-and-typename. WDYT?

Yes, but if we do that, (1) the users need to #include two header files instead
of one, and (2) the templates and the parameter structs will no longer be as
tightly confined as they are. If they aliases had been used in very few places I
would have agreed, but as it is they're used in enough places that I think it
makes sense to make the templates a hidden implementation detail.

Does this sound convincing enough that you won't just suspect me of being too
lazy to change the CL?

[ossu, 2017-08-17 10:15:55]

On 2017/08/16 11:48:58, kwiberg-webrtc wrote:
> On 2017/08/15 13:47:15, ossu wrote:
> > Maybe it's possible to get around this by just removing the aliases for the
> > Float and Fix variants instead. At this point, their aliases' names are
almost
> > as long as the full template-and-typename. WDYT?
> 
> Yes, but if we do that, (1) the users need to #include two header files
instead
> of one, and (2) the templates and the parameter structs will no longer be as
> tightly confined as they are. If they aliases had been used in very few places
I
> would have agreed, but as it is they're used in enough places that I think it
> makes sense to make the templates a hidden implementation detail.

Yeah, you're probably right. There's possibly some things about this that can be
cleaned up but that's outside the scope of this CL anyways.
 
> Does this sound convincing enough that you won't just suspect me of being too
> lazy to change the CL?

I might always suspect it somewhere deep inside. ;)
For now, this LGTM!

[kwiberg-webrtc, 2017-08-17 10:53:55]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-08-17 10:54:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-17 12:31:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1502967235588000,
"parent_rev": "7c206b5b6c25a583a408629e6ac21d1b2a1fc5fc", "commit_rev":
"6ff045f097529ab71fbe9233a712c4bdce3f440d"}

[commit-bot: I haz the power, 2017-08-17 12:31:36]

Description was changed from

==========
Give Audio{De,En}coderIsac* an "Impl" suffix, to free up the original names

I want to publish an API for iSAC in webrtc/api/, and I want to use
the class names Audio{De,En}coderIsac{Fix,Float}.

BUG=webrtc:7835, webrtc:7841
==========

to

==========
Give Audio{De,En}coderIsac* an "Impl" suffix, to free up the original names

I want to publish an API for iSAC in webrtc/api/, and I want to use
the class names Audio{De,En}coderIsac{Fix,Float}.

BUG=webrtc:7835, webrtc:7841

Review-Url: https://codereview.webrtc.org/2996593002
Cr-Commit-Position: refs/heads/master@{#19381}
Committed:
https://chromium.googlesource.com/external/webrtc/+/6ff045f097529ab71fbe9233a...
==========

[commit-bot: I haz the power, 2017-08-17 12:31:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/6ff045f097529ab71fbe9233a...