iSAC fixed-point implementation of the Audio{En,De}coderFactoryTemplate APIs

iSAC fixed-point implementation of the Audio{En,De}coderFactoryTemplate APIs

BUG=webrtc:7835, webrtc:7841
Review-Url: https://codereview.webrtc.org/2996693002
Cr-Commit-Position: refs/heads/master@{#19409}
Committed: https://chromium.googlesource.com/external/webrtc/+/327af331515570a44f30a1f6ea102c65029a7719

[kwiberg-webrtc, 2017-08-08 21:46:59]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-08 21:47:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-08-08 22:24:49]

kwiberg@webrtc.org changed reviewers:
+ ossu@webrtc.org

[commit-bot: I haz the power, 2017-08-08 23:11:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-08 23:11:19]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-08-10 00:11:50]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-10 00:12:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-10 01:16:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-10 01:16:21]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-08-10 12:39:28]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-10 12:39:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-10 13:18:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-10 13:18:06]

Dry run: Try jobs failed on following builders:
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)

[kwiberg-webrtc, 2017-08-17 13:16:48]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-17 13:16:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-08-17 13:33:54]

Uploaded a new patch set, where I've fixed all the things you pointed out in the
floating-point CL.

[commit-bot: I haz the power, 2017-08-17 15:36:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-17 15:36:48]

Dry run: This issue passed the CQ dry run.

[ossu, 2017-08-18 10:20:00]

https://codereview.webrtc.org/2996693002/diff/80001/webrtc/api/audio_codecs/i...
File webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.cc (right):

https://codereview.webrtc.org/2996693002/diff/80001/webrtc/api/audio_codecs/i...
webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.cc:22: if
(STR_CASE_CMP(format.name.c_str(), "ISAC") == 0 &&
Does this mean we'll eventually be removing CreateIsacConfig() in the
implementation? Don't like that we have the same functionality implemented twice
(or thrice, with the floating point variant as well).

[kwiberg-webrtc, 2017-08-18 10:47:21]

https://codereview.webrtc.org/2996693002/diff/80001/webrtc/api/audio_codecs/i...
File webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.cc (right):

https://codereview.webrtc.org/2996693002/diff/80001/webrtc/api/audio_codecs/i...
webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.cc:22: if
(STR_CASE_CMP(format.name.c_str(), "ISAC") == 0 &&
On 2017/08/18 10:19:59, ossu wrote:
> Does this mean we'll eventually be removing CreateIsacConfig() in the
> implementation? Don't like that we have the same functionality implemented
twice
> (or thrice, with the floating point variant as well). 

Yes, because the code over there will no longer need to be able to parse
SdpAudioFormat.

[ossu, 2017-08-18 11:03:17]

lgtm then! :)

[kwiberg-webrtc, 2017-08-18 11:06:57]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-08-18 11:07:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-18 11:09:40]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1503054417511610,
"parent_rev": "a28122f5cdd4c21c5674297e2cce14c8da15f9bc", "commit_rev":
"327af331515570a44f30a1f6ea102c65029a7719"}

[commit-bot: I haz the power, 2017-08-18 11:09:45]

Description was changed from

==========
iSAC fixed-point implementation of the Audio{En,De}coderFactoryTemplate APIs

BUG=webrtc:7835, webrtc:7841
==========

to

==========
iSAC fixed-point implementation of the Audio{En,De}coderFactoryTemplate APIs

BUG=webrtc:7835, webrtc:7841

Review-Url: https://codereview.webrtc.org/2996693002
Cr-Commit-Position: refs/heads/master@{#19409}
Committed:
https://chromium.googlesource.com/external/webrtc/+/327af331515570a44f30a1f6e...
==========

[commit-bot: I haz the power, 2017-08-18 11:09:46]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/327af331515570a44f30a1f6e...