Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2996353002: Restyle Observatory Memory Dashboard buttons (Closed)

Created:
3 years, 4 months ago by cbernaschina
Modified:
3 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Restyle Observatory Memory Dashboard buttons - More polished button style - Make Refresh and GC buttons styled as buttons R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/463dec513524e078e2c4bc332f8ce3ec8875ded1

Patch Set 1 #

Patch Set 2 : Manage disabled buttons #

Patch Set 3 : Better layout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -29 lines) Patch
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 4 chunks +59 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/memory/allocations.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/memory/profile.dart View 1 2 3 chunks +22 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
cbernaschina
3 years, 4 months ago (2017-08-21 16:03:30 UTC) #3
cbernaschina
3 years, 4 months ago (2017-08-21 20:33:15 UTC) #4
cbernaschina
3 years, 4 months ago (2017-08-22 00:45:32 UTC) #5
siva
lgtm
3 years, 4 months ago (2017-08-22 17:27:40 UTC) #6
cbernaschina
3 years, 4 months ago (2017-08-22 17:36:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
463dec513524e078e2c4bc332f8ce3ec8875ded1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698