Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: runtime/observatory/lib/src/elements/memory/profile.dart

Issue 2996353002: Restyle Observatory Memory Dashboard buttons (Closed)
Patch Set: Better layout Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/memory/allocations.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/memory/profile.dart
diff --git a/runtime/observatory/lib/src/elements/memory/profile.dart b/runtime/observatory/lib/src/elements/memory/profile.dart
index 34e52372d0fff3011f0bfef96605f06b1ab5638e..7d9541a7a8ae21469c07d04546311834947ca08d 100644
--- a/runtime/observatory/lib/src/elements/memory/profile.dart
+++ b/runtime/observatory/lib/src/elements/memory/profile.dart
@@ -116,8 +116,8 @@ class MemoryProfileElement extends HtmlElement implements Renderable {
..children = [
new Text("Isolate ${_isolate.name}"),
bReload
- ..classes = ['link', 'big']
- ..text = ' ↺ '
+ ..classes = ['header_button']
+ ..text = ' ↺ Refresh'
..title = 'Refresh'
..onClick.listen((e) async {
bReload.disabled = true;
@@ -127,8 +127,8 @@ class MemoryProfileElement extends HtmlElement implements Renderable {
bGC.disabled = false;
}),
bGC
- ..classes = ['link', 'big']
- ..text = ' ♺ '
+ ..classes = ['header_button']
+ ..text = ' ♺ Collect Garbage'
..title = 'Collect Garbage'
..onClick.listen((e) async {
bGC.disabled = true;
@@ -137,22 +137,24 @@ class MemoryProfileElement extends HtmlElement implements Renderable {
bGC.disabled = false;
bReload.disabled = false;
}),
- new ButtonElement()
- ..classes = ['tab_button']
- ..text = 'Dominator Tree'
- ..disabled = _analysis == _Analysis.dominatorTree
- ..onClick.listen((_) {
- _analysis = _Analysis.dominatorTree;
- _r.dirty();
- }),
- new ButtonElement()
- ..classes = ['tab_button']
- ..text = 'Allocations'
- ..disabled = _analysis == _Analysis.allocations
- ..onClick.listen((_) {
- _analysis = _Analysis.allocations;
- _r.dirty();
- }),
+ new SpanElement()
+ ..classes = ['tab_buttons']
+ ..children = [
+ new ButtonElement()
+ ..text = 'Allocations'
+ ..disabled = _analysis == _Analysis.allocations
+ ..onClick.listen((_) {
+ _analysis = _Analysis.allocations;
+ _r.dirty();
+ }),
+ new ButtonElement()
+ ..text = 'Dominator Tree'
+ ..disabled = _analysis == _Analysis.dominatorTree
+ ..onClick.listen((_) {
+ _analysis = _Analysis.dominatorTree;
+ _r.dirty();
+ }),
+ ]
],
],
current
« no previous file with comments | « runtime/observatory/lib/src/elements/memory/allocations.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698