Minor improvements to VideoProcessor and corresponding test.

Minor improvements to VideoProcessor and corresponding test.

- Make all overridden methods of VideoProcessorImpl public,
  in preparation of the removal of the VideoProcessor interface.
- Place corresponding method definitions in correct order
  in .cc file.
- Harmonize the stdout printing.
- Make timestamp calculations adhere to set frame rate.

Except for the last bullet, these changes should not lead to
different functionality.

BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2995513002
Cr-Commit-Position: refs/heads/master@{#19254}
Committed: https://chromium.googlesource.com/external/webrtc/+/bea36fdee86f7c5eb80dc9d1032b61af01e92ccb

[brandtr, 2017-08-04 13:52:03]

brandtr@webrtc.org changed reviewers:
+ asapersson@webrtc.org

[brandtr, 2017-08-07 06:40:35]

Not sure if I sent this out for review or not yet. Anyway, please take a look :)

[åsapersson, 2017-08-07 08:30:10]

lgtm with comment

https://codereview.webrtc.org/2995513002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/test/videoprocessor.cc (left):

https://codereview.webrtc.org/2995513002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/test/videoprocessor.cc:68:
CodecTypeToPayloadName(config->codecType).value_or("Unknown"));
Update plot_webrtc_test_logs.py accordingly?

[brandtr, 2017-08-07 09:21:46]

https://codereview.webrtc.org/2995513002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/test/videoprocessor.cc (left):

https://codereview.webrtc.org/2995513002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/test/videoprocessor.cc:68:
CodecTypeToPayloadName(config->codecType).value_or("Unknown"));
On 2017/08/07 08:30:10, åsapersson wrote:
> Update plot_webrtc_test_logs.py accordingly?

I had misread the "codec implementation name" field below, thinking it was the
same as this "Codec type" field. Readding the latter.

[brandtr, 2017-08-07 09:21:50]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-07 09:22:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-07 09:25:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-07 09:25:12]

Dry run: Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  linux_ubsan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/14362)

[brandtr, 2017-08-07 09:28:30]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-07 09:28:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-07 10:14:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-07 10:14:51]

Dry run: This issue passed the CQ dry run.

[brandtr, 2017-08-07 10:33:43]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2017-08-07 10:33:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2995513002/#ps40001 (title:
"Fix compile.")

[commit-bot: I haz the power, 2017-08-07 10:33:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-07 10:36:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1502102023058740,
"parent_rev": "669ea1917e4d2b7d64d3fe204b837bae724313c7", "commit_rev":
"bea36fdee86f7c5eb80dc9d1032b61af01e92ccb"}

[commit-bot: I haz the power, 2017-08-07 10:37:00]

Description was changed from

==========
Minor improvements to VideoProcessor and corresponding test.

- Make all overridden methods of VideoProcessorImpl public,
  in preparation of the removal of the VideoProcessor interface.
- Place corresponding method definitions in correct order
  in .cc file.
- Harmonize the stdout printing.
- Make timestamp calculations adhere to set frame rate.

Except for the last bullet, these changes should not lead to
different functionality.

BUG=webrtc:6634
==========

to

==========
Minor improvements to VideoProcessor and corresponding test.

- Make all overridden methods of VideoProcessorImpl public,
  in preparation of the removal of the VideoProcessor interface.
- Place corresponding method definitions in correct order
  in .cc file.
- Harmonize the stdout printing.
- Make timestamp calculations adhere to set frame rate.

Except for the last bullet, these changes should not lead to
different functionality.

BUG=webrtc:6634

Review-Url: https://codereview.webrtc.org/2995513002
Cr-Commit-Position: refs/heads/master@{#19254}
Committed:
https://chromium.googlesource.com/external/webrtc/+/bea36fdee86f7c5eb80dc9d10...
==========

[commit-bot: I haz the power, 2017-08-07 10:37:01]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/bea36fdee86f7c5eb80dc9d10...