Revert of quest keyframes more frequently on stream start/decoding error.

Revert of quest keyframes more frequently on stream start/decoding error. (patchset #2 id:170001 of https://codereview.webrtc.org/2996823002/ )

Reason for revert:
Causes iOS H264 calls received in the background to have increased delay before being able to decode stream from sender due to not having a keyframe.

Original issue's description:
> Reland of quest keyframes more frequently on stream start/decoding error. (patchset #1 id:1 of https://codereview.chromium.org/2994043002/ )
> 
> Reason for revert:
> Create fix CL.
> 
> Original issue's description:
> > Revert of Request keyframes more frequently on stream start/decoding error. (patchset #1 id:1 of https://codereview.webrtc.org/2993793002/ )
> > 
> > Reason for revert:
> > Broke downstream test that was waiting for 5 keyframes to be received within 10 seconds. Maybe the issue is that "stats_callback_->OnCompleteFrame(frame->num_references == 0, ..." was changed to "frame->is_keyframe()"?
> > 
> > Original issue's description:
> > > Request keyframes more frequently on stream start/decoding error.
> > > 
> > > In this CL:
> > >  - Added FrameObject::is_keyframe() convinience function.
> > >  - Moved logic to request keyframes on decoding error from VideoReceived to
> > >    VideoReceiveStream.
> > >  - Added keyframe_required as a parameter to FrameBuffer::NextFrame.
> > > 
> > > BUG=webrtc:8074
> > > 
> > > Review-Url: https://codereview.webrtc.org/2993793002
> > > Cr-Commit-Position: refs/heads/master@{#19280}
> > > Committed: https://chromium.googlesource.com/external/webrtc/+/26b48043581735eed6e36b95fae6f5b1bcf8cfb5
> > 
> > TBR=terelius@webrtc.org,stefan@webrtc.org,noahric@chromium.org,philipel@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:8074
> > 
> > Review-Url: https://codereview.webrtc.org/2994043002
> > Cr-Commit-Position: refs/heads/master@{#19295}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/77a983185f57628cd5955bd2c0a1bf71c30439bb
> 
> TBR=terelius@webrtc.org,stefan@webrtc.org,noahric@chromium.org,deadbeef@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> BUG=webrtc:8074
> 
> Review-Url: https://codereview.webrtc.org/2996823002
> Cr-Commit-Position: refs/heads/master@{#19324}
> Committed: https://chromium.googlesource.com/external/webrtc/+/628ac5964e32e66083a6ab14dceac6cb2cabe345

TBR=terelius@webrtc.org,stefan@webrtc.org,noahric@chromium.org,deadbeef@webrtc.org,philipel@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:8074
Review-Url: https://codereview.webrtc.org/2995153002
Cr-Commit-Position: refs/heads/master@{#19392}
Committed: https://chromium.googlesource.com/external/webrtc/+/53959fcc2ba580e7c87231708e5b4af7906f6836

[tkchin_webrtc, 2017-08-17 17:14:35]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2017-08-17 17:14:36]

Created Revert of quest keyframes more frequently on stream start/decoding
error.

[commit-bot: I haz the power, 2017-08-17 17:14:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-17 18:01:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1502990075626140, "parent_rev":
"200028fefcf86a927b20827e627a82f49070e344", "commit_rev":
"53959fcc2ba580e7c87231708e5b4af7906f6836"}

[commit-bot: I haz the power, 2017-08-17 18:01:53]

Description was changed from

==========
Revert of quest keyframes more frequently on stream start/decoding error.
(patchset #2 id:170001 of https://codereview.webrtc.org/2996823002/ )

Reason for revert:
Causes iOS H264 calls received in the background to have increased delay before
being able to decode stream from sender due to not having a keyframe.

Original issue's description:
> Reland of quest keyframes more frequently on stream start/decoding error.
(patchset #1 id:1 of https://codereview.chromium.org/2994043002/ )
> 
> Reason for revert:
> Create fix CL.
> 
> Original issue's description:
> > Revert of Request keyframes more frequently on stream start/decoding error.
(patchset #1 id:1 of https://codereview.webrtc.org/2993793002/ )
> > 
> > Reason for revert:
> > Broke downstream test that was waiting for 5 keyframes to be received within
10 seconds. Maybe the issue is that
"stats_callback_->OnCompleteFrame(frame->num_references == 0, ..." was changed
to "frame->is_keyframe()"?
> > 
> > Original issue's description:
> > > Request keyframes more frequently on stream start/decoding error.
> > > 
> > > In this CL:
> > >  - Added FrameObject::is_keyframe() convinience function.
> > >  - Moved logic to request keyframes on decoding error from VideoReceived
to
> > >    VideoReceiveStream.
> > >  - Added keyframe_required as a parameter to FrameBuffer::NextFrame.
> > > 
> > > BUG=webrtc:8074
> > > 
> > > Review-Url: https://codereview.webrtc.org/2993793002
> > > Cr-Commit-Position: refs/heads/master@{#19280}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/26b48043581735eed6e36b95f...
> > 
> >
TBR=terelius@webrtc.org,stefan@webrtc.org,noahric@chromium.org,philipel@webrt...
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:8074
> > 
> > Review-Url: https://codereview.webrtc.org/2994043002
> > Cr-Commit-Position: refs/heads/master@{#19295}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/77a983185f57628cd5955bd2c...
> 
>
TBR=terelius@webrtc.org,stefan@webrtc.org,noahric@chromium.org,deadbeef@webrt...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> BUG=webrtc:8074
> 
> Review-Url: https://codereview.webrtc.org/2996823002
> Cr-Commit-Position: refs/heads/master@{#19324}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/628ac5964e32e66083a6ab14d...

TBR=terelius@webrtc.org,stefan@webrtc.org,noahric@chromium.org,deadbeef@webrt...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:8074
==========

to

==========
Revert of quest keyframes more frequently on stream start/decoding error.
(patchset #2 id:170001 of https://codereview.webrtc.org/2996823002/ )

Reason for revert:
Causes iOS H264 calls received in the background to have increased delay before
being able to decode stream from sender due to not having a keyframe.

Original issue's description:
> Reland of quest keyframes more frequently on stream start/decoding error.
(patchset #1 id:1 of https://codereview.chromium.org/2994043002/ )
> 
> Reason for revert:
> Create fix CL.
> 
> Original issue's description:
> > Revert of Request keyframes more frequently on stream start/decoding error.
(patchset #1 id:1 of https://codereview.webrtc.org/2993793002/ )
> > 
> > Reason for revert:
> > Broke downstream test that was waiting for 5 keyframes to be received within
10 seconds. Maybe the issue is that
"stats_callback_->OnCompleteFrame(frame->num_references == 0, ..." was changed
to "frame->is_keyframe()"?
> > 
> > Original issue's description:
> > > Request keyframes more frequently on stream start/decoding error.
> > > 
> > > In this CL:
> > >  - Added FrameObject::is_keyframe() convinience function.
> > >  - Moved logic to request keyframes on decoding error from VideoReceived
to
> > >    VideoReceiveStream.
> > >  - Added keyframe_required as a parameter to FrameBuffer::NextFrame.
> > > 
> > > BUG=webrtc:8074
> > > 
> > > Review-Url: https://codereview.webrtc.org/2993793002
> > > Cr-Commit-Position: refs/heads/master@{#19280}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/26b48043581735eed6e36b95f...
> > 
> >
TBR=terelius@webrtc.org,stefan@webrtc.org,noahric@chromium.org,philipel@webrt...
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:8074
> > 
> > Review-Url: https://codereview.webrtc.org/2994043002
> > Cr-Commit-Position: refs/heads/master@{#19295}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/77a983185f57628cd5955bd2c...
> 
>
TBR=terelius@webrtc.org,stefan@webrtc.org,noahric@chromium.org,deadbeef@webrt...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> BUG=webrtc:8074
> 
> Review-Url: https://codereview.webrtc.org/2996823002
> Cr-Commit-Position: refs/heads/master@{#19324}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/628ac5964e32e66083a6ab14d...

TBR=terelius@webrtc.org,stefan@webrtc.org,noahric@chromium.org,deadbeef@webrt...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:8074

Review-Url: https://codereview.webrtc.org/2995153002
Cr-Commit-Position: refs/heads/master@{#19392}
Committed:
https://chromium.googlesource.com/external/webrtc/+/53959fcc2ba580e7c87231708...
==========

[commit-bot: I haz the power, 2017-08-17 18:01:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/53959fcc2ba580e7c87231708...

[philipel, 2017-08-18 10:49:03]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2996153003/ by philipel@webrtc.org.

The reason for reverting is: iOS workaround..