Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: webrtc/modules/video_coding/video_receiver.cc

Issue 2995153002: Revert of quest keyframes more frequently on stream start/decoding error. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/frame_object.h ('k') | webrtc/video/video_receive_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/video_receiver.cc
diff --git a/webrtc/modules/video_coding/video_receiver.cc b/webrtc/modules/video_coding/video_receiver.cc
index de6764f9b54e1cd23522f6d5837bf0242420dbad..3d3e155dc3e1a6417cc5a255f5406603435a76a7 100644
--- a/webrtc/modules/video_coding/video_receiver.cc
+++ b/webrtc/modules/video_coding/video_receiver.cc
@@ -320,7 +320,24 @@
if (decoder == nullptr) {
return VCM_NO_CODEC_REGISTERED;
}
- return decoder->Decode(frame, clock_->TimeInMilliseconds());
+ // Decode a frame
+ int32_t ret = decoder->Decode(frame, clock_->TimeInMilliseconds());
+
+ // Check for failed decoding, run frame type request callback if needed.
+ bool request_key_frame = false;
+ if (ret < 0) {
+ request_key_frame = true;
+ }
+
+ if (!frame.Complete() || frame.MissingFrame()) {
+ request_key_frame = true;
+ ret = VCM_OK;
+ }
+ if (request_key_frame) {
+ rtc::CritScope cs(&process_crit_);
+ _scheduleKeyRequest = true;
+ }
+ return ret;
}
// Register possible receive codecs, can be called multiple times
« no previous file with comments | « webrtc/modules/video_coding/frame_object.h ('k') | webrtc/video/video_receive_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698