Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2995073002: When using clang, switch on -Wc++11-narrowing (Closed)

Created:
3 years, 4 months ago by kwiberg-webrtc
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

When using clang, switch on -Wc++11-narrowing See https://clang.llvm.org/docs/DiagnosticsReference.html#wc-11-narrowing for datails. This catches a narrowing bug that broke a downstream project in https://codereview.webrtc.org/2995523002/. BUG=none Review-Url: https://codereview.webrtc.org/2995073002 Cr-Commit-Position: refs/heads/master@{#19366} Committed: https://chromium.googlesource.com/external/webrtc/+/5b9746ef10a3042abd766430197fd1bc0dade648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes_unittest.cc View 7 chunks +17 lines, -17 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/rtc_base/task_queue_libevent.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
kwiberg-webrtc
It seems to work now! PTAL.
3 years, 4 months ago (2017-08-16 11:38:41 UTC) #12
charujain
lgtm
3 years, 4 months ago (2017-08-16 11:44:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2995073002/20001
3 years, 4 months ago (2017-08-16 11:49:43 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/5b9746ef10a3042abd766430197fd1bc0dade648
3 years, 4 months ago (2017-08-16 11:52:49 UTC) #18
kjellander_webrtc
3 years, 4 months ago (2017-08-16 12:30:46 UTC) #19
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698