Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: webrtc/rtc_base/task_queue_libevent.cc

Issue 2995073002: When using clang, switch on -Wc++11-narrowing (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/video_coding/frame_buffer2_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/rtc_base/task_queue.h" 11 #include "webrtc/rtc_base/task_queue.h"
12 12
13 #include <fcntl.h> 13 #include <fcntl.h>
14 #include <signal.h> 14 #include <signal.h>
15 #include <string.h> 15 #include <string.h>
16 #include <unistd.h> 16 #include <unistd.h>
17 17
18 #include "base/third_party/libevent/event.h" 18 #include "base/third_party/libevent/event.h"
19 #include "webrtc/rtc_base/checks.h" 19 #include "webrtc/rtc_base/checks.h"
20 #include "webrtc/rtc_base/logging.h" 20 #include "webrtc/rtc_base/logging.h"
21 #include "webrtc/rtc_base/safe_conversions.h"
21 #include "webrtc/rtc_base/task_queue_posix.h" 22 #include "webrtc/rtc_base/task_queue_posix.h"
22 #include "webrtc/rtc_base/timeutils.h" 23 #include "webrtc/rtc_base/timeutils.h"
23 24
24 namespace rtc { 25 namespace rtc {
25 using internal::GetQueuePtrTls; 26 using internal::GetQueuePtrTls;
26 using internal::AutoSetCurrentQueuePtr; 27 using internal::AutoSetCurrentQueuePtr;
27 28
28 namespace { 29 namespace {
29 static const char kQuit = 1; 30 static const char kQuit = 1;
30 static const char kRunTask = 2; 31 static const char kRunTask = 2;
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 } 311 }
311 312
312 void TaskQueue::PostDelayedTask(std::unique_ptr<QueuedTask> task, 313 void TaskQueue::PostDelayedTask(std::unique_ptr<QueuedTask> task,
313 uint32_t milliseconds) { 314 uint32_t milliseconds) {
314 if (IsCurrent()) { 315 if (IsCurrent()) {
315 TimerEvent* timer = new TimerEvent(std::move(task)); 316 TimerEvent* timer = new TimerEvent(std::move(task));
316 EventAssign(&timer->ev, event_base_, -1, 0, &TaskQueue::RunTimer, timer); 317 EventAssign(&timer->ev, event_base_, -1, 0, &TaskQueue::RunTimer, timer);
317 QueueContext* ctx = 318 QueueContext* ctx =
318 static_cast<QueueContext*>(pthread_getspecific(GetQueuePtrTls())); 319 static_cast<QueueContext*>(pthread_getspecific(GetQueuePtrTls()));
319 ctx->pending_timers_.push_back(timer); 320 ctx->pending_timers_.push_back(timer);
320 timeval tv = {milliseconds / 1000, (milliseconds % 1000) * 1000}; 321 timeval tv = {rtc::dchecked_cast<int>(milliseconds / 1000),
322 rtc::dchecked_cast<int>(milliseconds % 1000) * 1000};
321 event_add(&timer->ev, &tv); 323 event_add(&timer->ev, &tv);
322 } else { 324 } else {
323 PostTask(std::unique_ptr<QueuedTask>( 325 PostTask(std::unique_ptr<QueuedTask>(
324 new SetTimerTask(std::move(task), milliseconds))); 326 new SetTimerTask(std::move(task), milliseconds)));
325 } 327 }
326 } 328 }
327 329
328 void TaskQueue::PostTaskAndReply(std::unique_ptr<QueuedTask> task, 330 void TaskQueue::PostTaskAndReply(std::unique_ptr<QueuedTask> task,
329 std::unique_ptr<QueuedTask> reply, 331 std::unique_ptr<QueuedTask> reply,
330 TaskQueue* reply_queue) { 332 TaskQueue* reply_queue) {
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
420 delete timer; 422 delete timer;
421 } 423 }
422 424
423 void TaskQueue::PrepareReplyTask(scoped_refptr<ReplyTaskOwnerRef> reply_task) { 425 void TaskQueue::PrepareReplyTask(scoped_refptr<ReplyTaskOwnerRef> reply_task) {
424 RTC_DCHECK(reply_task); 426 RTC_DCHECK(reply_task);
425 CritScope lock(&pending_lock_); 427 CritScope lock(&pending_lock_);
426 pending_replies_.push_back(std::move(reply_task)); 428 pending_replies_.push_back(std::move(reply_task));
427 } 429 }
428 430
429 } // namespace rtc 431 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/frame_buffer2_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698