Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2994743002: Remove old webrtc/base directory (Closed)

Created:
3 years, 4 months ago by mbonadei
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove old webrtc/base directory The content of webrtc/base has been moved to webrtc/rtc_base and we can now remove the original directory. BUG=webrtc:7634 Review-Url: https://codereview.webrtc.org/2994743002 Cr-Commit-Position: refs/heads/master@{#19361} Committed: https://chromium.googlesource.com/external/webrtc/+/2b05ba1874cd71ed36c5a5b7094ed1d6018db23f

Patch Set 1 #

Patch Set 2 : Removing PRESUBMIT check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M PRESUBMIT.py View 1 2 chunks +0 lines, -21 lines 0 comments Download
D webrtc/base/README.md View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mbonadei
3 years, 4 months ago (2017-08-08 12:48:33 UTC) #2
ehmaldonado_webrtc
3 years, 4 months ago (2017-08-08 13:09:45 UTC) #4
kwiberg-webrtc
lgtm
3 years, 4 months ago (2017-08-15 23:20:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2994743002/20001
3 years, 4 months ago (2017-08-16 06:14:27 UTC) #9
commit-bot: I haz the power
3 years, 4 months ago (2017-08-16 06:41:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/2b05ba1874cd71ed36c5a5b70...

Powered by Google App Engine
This is Rietveld 408576698