Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: PRESUBMIT.py

Issue 2994743002: Remove old webrtc/base directory (Closed)
Patch Set: Removing PRESUBMIT check Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/base/README.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index d29c4c41a04a14266ccb564b86eca9884c0d80d7..2a22d73f5d387478a5cc87e2373d9b2a88d7c3dd 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -509,26 +509,6 @@ def _CheckUsageOfGoogleProtobufNamespace(input_api, output_api):
return []
-def _CheckNoChangesToWebRTCBase(input_api, output_api):
- """Checks that no changes refer to webrtc/base."""
- problems = []
-
- for f in input_api.AffectedFiles():
- if os.path.join('webrtc', 'base') in f.LocalPath():
- problems.append(' ' + f.LocalPath())
- continue
- for line_num, line in f.ChangedContents():
- if 'webrtc/base' in line:
- problems.append(' %s: %s' % (f.LocalPath(), line_num))
-
- if problems:
- return [output_api.PresubmitPromptWarning(
- 'webrtc/base is being moved to webrtc/rtc_base (See '
- 'bugs.webrtc.org/7634). Please refer to webrtc/rtc_base instead in the '
- 'following files:\n' + '\n'.join(problems))]
- return []
-
-
def _CommonChecks(input_api, output_api):
"""Checks common to both upload and commit."""
results = []
@@ -597,7 +577,6 @@ def _CommonChecks(input_api, output_api):
results.extend(_CheckUsageOfGoogleProtobufNamespace(input_api, output_api))
results.extend(_CheckOrphanHeaders(input_api, output_api))
results.extend(_CheckNewLineAtTheEndOfProtoFiles(input_api, output_api))
- results.extend(_CheckNoChangesToWebRTCBase(input_api, output_api))
return results
« no previous file with comments | « no previous file | webrtc/base/README.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698