Renamed fields in rtp_rtcp_defines.h/RTCPReportBlock

Renamed fields in rtp_rtcp_defines.h/RTCPReportBlock

Continues on https://codereview.webrtc.org/2992043002

BUG=webrtc:8033
Review-Url: https://codereview.webrtc.org/2994633002
Cr-Commit-Position: refs/heads/master@{#19286}
Committed: https://chromium.googlesource.com/external/webrtc/+/3e69e5c2c0450002a03be5184f28647efccbb47a

[srte, 2017-08-04 15:12:12]

Description was changed from

==========
Renamed fields in rtp_rtcp_defines.h/RTCPReportBlock

BUG=webrtc:8033
==========

to

==========
Renamed fields in rtp_rtcp_defines.h/RTCPReportBlock

Continues on https://codereview.webrtc.org/2992043002

BUG=webrtc:8033
==========

[srte, 2017-08-04 15:12:12]

srte@webrtc.org changed reviewers:
+ henrika@webrtc.org, stefan@webrtc.org

[srte, 2017-08-04 15:17:16]

srte@webrtc.org changed reviewers:
+ asapersson@webrtc.org
- henrika@webrtc.org

[stefan-webrtc, 2017-08-07 10:43:24]

lgtm

https://codereview.webrtc.org/2994633002/diff/1/webrtc/voice_engine/channel.cc
File webrtc/voice_engine/channel.cc (right):

https://codereview.webrtc.org/2994633002/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:3147: uint32_t remoteSSRC =
rtp_receiver_->SSRC();
Would be nice to also change this to sender_ssrc.

[åsapersson, 2017-08-07 11:46:42]

lgtm

[srte, 2017-08-07 12:17:30]

https://codereview.webrtc.org/2994633002/diff/1/webrtc/voice_engine/channel.cc
File webrtc/voice_engine/channel.cc (right):

https://codereview.webrtc.org/2994633002/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:3147: uint32_t remoteSSRC =
rtp_receiver_->SSRC();
On 2017/08/07 10:43:24, stefan-webrtc wrote:
> Would be nice to also change this to sender_ssrc.

While that would not be wrong, I'm not sure it'd actually provide any
improvement, as it actually makes some sense in that context to call it the
remote ssrc as it is the remote ssrc reported by the RTP Receiver. Maybe worth
it to call it remote_ssrc to follow the naming convetion.

I've tried to make the changeset minimal to make it easier to follow and
understand.

[srte, 2017-08-09 12:43:55]

The CQ bit was checked by srte@webrtc.org

[commit-bot: I haz the power, 2017-08-09 12:44:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-09 13:13:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1502282635256070, "parent_rev":
"f1e08d0b5848d32fd31c5b6e4e570115c32b7ce5", "commit_rev":
"3e69e5c2c0450002a03be5184f28647efccbb47a"}

[commit-bot: I haz the power, 2017-08-09 13:13:51]

Description was changed from

==========
Renamed fields in rtp_rtcp_defines.h/RTCPReportBlock

Continues on https://codereview.webrtc.org/2992043002

BUG=webrtc:8033
==========

to

==========
Renamed fields in rtp_rtcp_defines.h/RTCPReportBlock

Continues on https://codereview.webrtc.org/2992043002

BUG=webrtc:8033

Review-Url: https://codereview.webrtc.org/2994633002
Cr-Commit-Position: refs/heads/master@{#19286}
Committed:
https://chromium.googlesource.com/external/webrtc/+/3e69e5c2c0450002a03be5184...
==========

[commit-bot: I haz the power, 2017-08-09 13:13:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/3e69e5c2c0450002a03be5184...