Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2992043002: Renamed fields in common_types.h/RtcpStatistics. (Closed)

Created:
3 years, 4 months ago by srte
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), kwiberg-webrtc, stefan-webrtc, Andrew MacDonald, zhuangzesen_agora.io, henrika_webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun, AleBzk, zhengzhonghou_agora.io, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Renamed fields in common_types.h/RtcpStatistics. BUG=webrtc:8033 Review-Url: https://codereview.webrtc.org/2992043002 Cr-Commit-Position: refs/heads/master@{#19247} Committed: https://chromium.googlesource.com/external/webrtc/+/186d9c38733a5e4151be7df55a1220a8c47c8bf4

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase on new master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -70 lines) Patch
M webrtc/common_types.h View 2 chunks +11 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/rtcp.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M webrtc/video/report_block_stats.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/report_block_stats_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
srte
3 years, 4 months ago (2017-08-01 07:59:12 UTC) #3
kwiberg-webrtc
lgtm for the mechanics of the rename. I'm not in a position to verify whether ...
3 years, 4 months ago (2017-08-01 08:26:51 UTC) #5
åsapersson
lgtm
3 years, 4 months ago (2017-08-01 15:23:20 UTC) #6
sprang_webrtc
lgtm make sure you test with downstream projects though
3 years, 4 months ago (2017-08-02 08:24:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2992043002/20001
3 years, 4 months ago (2017-08-04 09:45:19 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-04 12:04:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/186d9c38733a5e4151be7df55...

Powered by Google App Engine
This is Rietveld 408576698