Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc

Issue 2992043002: Renamed fields in common_types.h/RtcpStatistics. (Closed)
Patch Set: Rebase on new master Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc
diff --git a/webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc b/webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc
index 150c88b4266c910cd6b30b6a3902cb5a2265a740..7ac86ee0f29499eb0cbe61a8772801b010b21c07 100644
--- a/webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc
+++ b/webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc
@@ -265,8 +265,8 @@ RtcpStatistics StreamStatisticianImpl::CalculateRtcpStatistics() {
// We need a counter for cumulative loss too.
// TODO(danilchap): Ensure cumulative loss is below maximum value of 2^24.
cumulative_loss_ += missing;
- stats.cumulative_lost = cumulative_loss_;
- stats.extended_max_sequence_number =
+ stats.packets_lost = cumulative_loss_;
+ stats.extended_highest_sequence_number =
(received_seq_wraps_ << 16) + received_seq_max_;
// Note: internal jitter value is in Q4 and needs to be scaled by 1/16.
stats.jitter = jitter_q4_ >> 4;
@@ -514,12 +514,12 @@ std::vector<rtcp::ReportBlock> ReceiveStatistics::RtcpReportBlocks(
rtcp::ReportBlock& block = result.back();
block.SetMediaSsrc(statistician.first);
block.SetFractionLost(stats.fraction_lost);
- if (!block.SetCumulativeLost(stats.cumulative_lost)) {
+ if (!block.SetCumulativeLost(stats.packets_lost)) {
LOG(LS_WARNING) << "Cumulative lost is oversized.";
result.pop_back();
continue;
}
- block.SetExtHighestSeqNum(stats.extended_max_sequence_number);
+ block.SetExtHighestSeqNum(stats.extended_highest_sequence_number);
block.SetJitter(stats.jitter);
}
return result;

Powered by Google App Engine
This is Rietveld 408576698