Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2992233002: Destroy compression session instead of reset it on release. (Closed)

Created:
3 years, 4 months ago by kthelgason
Modified:
3 years, 4 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, magjed_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Destroy compression session instead of reset it on release. This will prevent one extra initialization of the encoder each time it's recreated. BUG=None Review-Url: https://codereview.webrtc.org/2992233002 Cr-Commit-Position: refs/heads/master@{#19250} Committed: https://chromium.googlesource.com/external/webrtc/+/d48f56de1f06d62fcb46bb9f20bd5f336e80aae9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
kthelgason
On 2017/08/03 20:43:12, kthelgason wrote: > mailto:kthelgason@webrtc.org changed reviewers: > + mailto:tkchin@webrtc.org Zeke, PTAL.
3 years, 4 months ago (2017-08-03 20:43:53 UTC) #7
tkchin_webrtc
as long as release is called exactly once when it's not longer needed, lgtm
3 years, 4 months ago (2017-08-03 23:43:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2992233002/1
3 years, 4 months ago (2017-08-04 17:16:02 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-04 17:18:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d48f56de1f06d62fcb46bb9f2...

Powered by Google App Engine
This is Rietveld 408576698