Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm

Issue 2992233002: Destroy compression session instead of reset it on release. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm
index 2e87458fe83cb0675b1d7a6de5dab19a3d5080a4..2bac68ef6de3185525711edb5faf41f5214eb662 100644
--- a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm
+++ b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm
@@ -534,12 +534,12 @@ int H264VideoToolboxEncoder::SetRates(uint32_t new_bitrate_kbit,
}
int H264VideoToolboxEncoder::Release() {
- // Need to reset so that the session is invalidated and won't use the
+ // Need to destroy so that the session is invalidated and won't use the
// callback anymore. Do not remove callback until the session is invalidated
// since async encoder callbacks can occur until invalidation.
- int ret = ResetCompressionSession();
+ DestroyCompressionSession();
callback_ = nullptr;
- return ret;
+ return WEBRTC_VIDEO_CODEC_OK;
}
int H264VideoToolboxEncoder::ResetCompressionSession() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698