Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2989613002: Rename isolated_output to test_output and add a method to get the test_output directory. (Closed)

Created:
3 years, 5 months ago by ilnik
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename isolated_output to test_output and add a method to get the test_output directory. BUG=none TBR=kjellander@webrtc.org patch from issue 2990533002 at patchset 1 (http://crrev.com/2990533002#ps1) Already lgtm'ed in original issue. This only fixes trivial compilation errors. Review-Url: https://codereview.webrtc.org/2989613002 Cr-Commit-Position: refs/heads/master@{#19133} Committed: https://chromium.googlesource.com/external/webrtc/+/e264a9ee9c7581ea204325f05c18d3dcd7c67b53

Patch Set 1 : Original patch by ehmaldonado, reviewed by kjellander #

Patch Set 2 : Fix CE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -184 lines) Patch
M webrtc/test/BUILD.gn View 3 chunks +5 lines, -5 lines 0 comments Download
D webrtc/test/testsupport/isolated_output.h View 1 chunk +0 lines, -35 lines 0 comments Download
D webrtc/test/testsupport/isolated_output.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D webrtc/test/testsupport/isolated_output_unittest.cc View 1 chunk +0 lines, -61 lines 0 comments Download
A + webrtc/test/testsupport/test_output.h View 2 chunks +11 lines, -7 lines 0 comments Download
A + webrtc/test/testsupport/test_output.cc View 1 3 chunks +23 lines, -13 lines 0 comments Download
A + webrtc/test/testsupport/test_output_unittest.cc View 1 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2989613002/20001
3 years, 5 months ago (2017-07-25 14:23:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/e264a9ee9c7581ea204325f05c18d3dcd7c67b53
3 years, 5 months ago (2017-07-25 14:31:23 UTC) #9
ehmaldonado_webrtc
3 years, 5 months ago (2017-07-25 15:36:43 UTC) #10
Message was sent while issue was closed.
On 2017/07/25 14:31:23, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/external/webrtc/+/e264a9ee9c7581ea204325f05...

lgtm thanks!

Powered by Google App Engine
This is Rietveld 408576698