Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: webrtc/test/testsupport/isolated_output_unittest.cc

Issue 2989613002: Rename isolated_output to test_output and add a method to get the test_output directory. (Closed)
Patch Set: Fix CE Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/test/testsupport/isolated_output.cc ('k') | webrtc/test/testsupport/test_output.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/testsupport/isolated_output_unittest.cc
diff --git a/webrtc/test/testsupport/isolated_output_unittest.cc b/webrtc/test/testsupport/isolated_output_unittest.cc
deleted file mode 100644
index bb75ebfe14bb56ddfc1b2b80d01579c07b5ef5a0..0000000000000000000000000000000000000000
--- a/webrtc/test/testsupport/isolated_output_unittest.cc
+++ /dev/null
@@ -1,61 +0,0 @@
-/*
- * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
- *
- * Use of this source code is governed by a BSD-style license
- * that can be found in the LICENSE file in the root of the source
- * tree. An additional intellectual property rights grant can be found
- * in the file PATENTS. All contributing project authors may
- * be found in the AUTHORS file in the root of the source tree.
- */
-
-#include "webrtc/test/testsupport/isolated_output.h"
-
-#include <string.h>
-
-#include <string>
-
-#include "gflags/gflags.h"
-#include "webrtc/rtc_base/file.h"
-#include "webrtc/rtc_base/pathutils.h"
-#include "webrtc/rtc_base/platform_file.h"
-#include "webrtc/test/gtest.h"
-
-DECLARE_string(isolated_out_dir);
-
-namespace webrtc {
-namespace test {
-
-TEST(IsolatedOutputTest, ShouldRejectInvalidIsolatedOutDir) {
- std::string backup = FLAGS_isolated_out_dir;
- FLAGS_isolated_out_dir = "";
- ASSERT_FALSE(WriteIsolatedOutput("a-file", "some-contents"));
- FLAGS_isolated_out_dir = backup;
-}
-
-TEST(IsolatedOutputTest, ShouldRejectInvalidFileName) {
- ASSERT_FALSE(WriteIsolatedOutput(nullptr, "some-contents"));
- ASSERT_FALSE(WriteIsolatedOutput("", "some-contents"));
-}
-
-// Sets isolated_out_dir=<a-writable-path> to execute this test.
-TEST(IsolatedOutputTest, ShouldBeAbleToWriteContent) {
- const char* filename = "a-file";
- const char* content = "some-contents";
- if (WriteIsolatedOutput(filename, content)) {
- rtc::Pathname out_file(FLAGS_isolated_out_dir, filename);
- rtc::File input = rtc::File::Open(out_file);
- EXPECT_TRUE(input.IsOpen());
- EXPECT_TRUE(input.Seek(0));
- uint8_t buffer[32];
- EXPECT_EQ(input.Read(buffer, strlen(content)), strlen(content));
- buffer[strlen(content)] = 0;
- EXPECT_EQ(std::string(content),
- std::string(reinterpret_cast<char*>(buffer)));
- input.Close();
-
- EXPECT_TRUE(rtc::File::Remove(out_file));
- }
-}
-
-} // namespace test
-} // namespace webrtc
« no previous file with comments | « webrtc/test/testsupport/isolated_output.cc ('k') | webrtc/test/testsupport/test_output.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698