Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2988783002: Removed file RTCCameraVideoCapturer.mm that isn't needed (Closed)

Created:
3 years, 5 months ago by jtt_webrtc
Modified:
3 years, 5 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed file RTCCameraVideoCapturer.mm that isn't needed Also added post commit review changes. BUG=webrtc:7898 Review-Url: https://codereview.webrtc.org/2988783002 Cr-Commit-Position: refs/heads/master@{#19145} Committed: https://chromium.googlesource.com/external/webrtc/+/3b673c66a4dde1d1d8e1737ef6b2ff93f415d6f4

Patch Set 1 #

Patch Set 2 : Added changes from review of 2964703002 after commit. #

Messages

Total messages: 12 (5 generated)
jtt_webrtc
RTCCameraVideoCapturer.mm was added when it shouldn't. RTCCameraVideoCapturer.m is the up to date file.
3 years, 5 months ago (2017-07-25 18:58:17 UTC) #2
tkchin_webrtc
On 2017/07/25 18:58:17, jtt_webrtc wrote: > RTCCameraVideoCapturer.mm was added when it shouldn't. > RTCCameraVideoCapturer.m is ...
3 years, 5 months ago (2017-07-25 19:34:35 UTC) #3
jtt_webrtc
On 2017/07/25 19:34:35, tkchin_webrtc wrote: > On 2017/07/25 18:58:17, jtt_webrtc wrote: > > RTCCameraVideoCapturer.mm was ...
3 years, 5 months ago (2017-07-25 19:53:04 UTC) #4
jtt_webrtc
Added changes from review comments from 2964703002.
3 years, 5 months ago (2017-07-25 20:14:14 UTC) #6
tkchin_webrtc
lgtm
3 years, 5 months ago (2017-07-25 22:03:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2988783002/20001
3 years, 5 months ago (2017-07-25 22:03:44 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-25 22:48:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/3b673c66a4dde1d1d8e1737ef...

Powered by Google App Engine
This is Rietveld 408576698