webrtc/sdk/objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.mm - Issue 2988783002: Removed file RTCCameraVideoCapturer.mm that isn't needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.mm

Issue 2988783002: Removed file RTCCameraVideoCapturer.mm that isn't needed (Closed)

Patch Set: Added changes from review of 2964703002 after commit. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/sdk/objc/Framework/Classes/Video/AVCaptureSession+DevicePosition.mm ('k') | webrtc/sdk/objc/Framework/UnitTests/RTCCameraVideoCapturerTests.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/sdk/objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.mm

diff --git a/webrtc/sdk/objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.mm b/webrtc/sdk/objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.mm

index 111f199e565014944cf668b79adac5d173920359..287ecdd71dc28e81676b1ab32e5279e648676bd8 100644

--- a/webrtc/sdk/objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.mm

+++ b/webrtc/sdk/objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.mm

@@ -16,7 +16,7 @@

#import "WebRTC/UIDevice+RTCDevice.h"

#endif

-#import "AVCaptureSession+Device.h"

+#import "AVCaptureSession+DevicePosition.h"

#import "RTCDispatcher+Private.h"

#import "WebRTC/RTCLogging.h"

@@ -218,7 +218,7 @@

#if TARGET_OS_IPHONE

// Default to portrait orientation on iPhone.

webrtc::VideoRotation rotation = webrtc::kVideoRotation_90;

- BOOL usingFrontCamera;

+ BOOL usingFrontCamera = NO;

// Check the image's EXIF for the camera the image came from as the image could have been

// delayed as we set alwaysDiscardsLateVideoFrames to NO.

AVCaptureDevicePosition cameraPosition =