Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 2988763002: Take smaller interface for RtpRtcp::Configuration::receive_statistics (Closed)

Created:
3 years, 5 months ago by danilchap
Modified:
3 years, 4 months ago
Reviewers:
eladalon
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman, åsapersson
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Take smaller interface for RtpRtcp::Configuration::receive_statistics BUG=webrtc:8016 Review-Url: https://codereview.webrtc.org/2988763002 Cr-Commit-Position: refs/heads/master@{#19167} Committed: https://chromium.googlesource.com/external/webrtc/+/f5f793c2ed4e85253ca5c6171a3988d2ba587800

Patch Set 1 : . #

Patch Set 2 : rerenaming #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -33 lines) Patch
M webrtc/modules/rtp_rtcp/include/receive_statistics.h View 1 3 chunks +17 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc View 1 2 chunks +33 lines, -0 lines 2 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 2 chunks +5 lines, -27 lines 3 comments Download

Messages

Total messages: 16 (10 generated)
danilchap
3 years, 4 months ago (2017-07-26 12:14:16 UTC) #4
eladalon
lgtm https://codereview.webrtc.org/2988763002/diff/40001/webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc File webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc (right): https://codereview.webrtc.org/2988763002/diff/40001/webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc#newcode518 webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc:518: LOG(LS_WARNING) << "Cumulative lost is oversized."; Would logging ...
3 years, 4 months ago (2017-07-27 09:07:31 UTC) #5
danilchap
https://codereview.webrtc.org/2988763002/diff/40001/webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc File webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc (right): https://codereview.webrtc.org/2988763002/diff/40001/webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc#newcode518 webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc:518: LOG(LS_WARNING) << "Cumulative lost is oversized."; On 2017/07/27 09:07:31, ...
3 years, 4 months ago (2017-07-27 10:04:32 UTC) #6
eladalon
https://codereview.webrtc.org/2988763002/diff/40001/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right): https://codereview.webrtc.org/2988763002/diff/40001/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc#newcode842 webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:842: result = receive_statistics_->RtcpReportBlocks(RTCP_MAX_REPORT_BLOCKS); On 2017/07/27 10:04:32, danilchap wrote: > ...
3 years, 4 months ago (2017-07-27 10:40:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2988763002/40001
3 years, 4 months ago (2017-07-27 11:41:57 UTC) #13
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 11:44:25 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/f5f793c2ed4e85253ca5c6171...

Powered by Google App Engine
This is Rietveld 408576698