Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1864)

Unified Diff: webrtc/modules/rtp_rtcp/include/receive_statistics.h

Issue 2988763002: Take smaller interface for RtpRtcp::Configuration::receive_statistics (Closed)
Patch Set: rerenaming Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/include/receive_statistics.h
diff --git a/webrtc/modules/rtp_rtcp/include/receive_statistics.h b/webrtc/modules/rtp_rtcp/include/receive_statistics.h
index 90a848ad6335bd7584a67e013b2d7e7c7a7d820f..edbaf8f6f8a1d37a61d0bd211b1b86b5b70cb74d 100644
--- a/webrtc/modules/rtp_rtcp/include/receive_statistics.h
+++ b/webrtc/modules/rtp_rtcp/include/receive_statistics.h
@@ -12,15 +12,26 @@
#define WEBRTC_MODULES_RTP_RTCP_INCLUDE_RECEIVE_STATISTICS_H_
#include <map>
+#include <vector>
#include "webrtc/modules/include/module.h"
#include "webrtc/modules/include/module_common_types.h"
+#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.h"
#include "webrtc/typedefs.h"
namespace webrtc {
class Clock;
+class ReceiveStatisticsProvider {
+ public:
+ virtual ~ReceiveStatisticsProvider() = default;
+ // Collects receive statistic in a form of rtcp report blocks.
+ // Returns at most |max_blocks| report blocks.
+ virtual std::vector<rtcp::ReportBlock> RtcpReportBlocks(
+ size_t max_blocks) = 0;
+};
+
class StreamStatistician {
public:
virtual ~StreamStatistician();
@@ -46,9 +57,9 @@ class StreamStatistician {
typedef std::map<uint32_t, StreamStatistician*> StatisticianMap;
-class ReceiveStatistics {
+class ReceiveStatistics : public ReceiveStatisticsProvider {
public:
- virtual ~ReceiveStatistics() {}
+ ~ReceiveStatistics() override = default;
static ReceiveStatistics* Create(Clock* clock);
@@ -78,6 +89,10 @@ class ReceiveStatistics {
// Called on new RTP stats creation.
virtual void RegisterRtpStatisticsCallback(
StreamDataCountersCallback* callback) = 0;
+
+ // TODO(danilchap): Make pure virtual when all implmentations of the
+ // ReceiveStatistics interface will implement it.
+ std::vector<rtcp::ReportBlock> RtcpReportBlocks(size_t max_blocks) override;
};
class NullReceiveStatistics : public ReceiveStatistics {
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/include/rtp_rtcp.h » ('j') | webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698