Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: webrtc/modules/pacing/alr_detector.h

Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension. (Closed)
Patch Set: Add metrics sliced on AlrExperiment group Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/pacing/alr_detector.h
diff --git a/webrtc/modules/pacing/alr_detector.h b/webrtc/modules/pacing/alr_detector.h
index 0dcd9effd006c4343e8b2f6e05850cab20004b2a..b0fc1bd37c7c98ed436aeb0b50a7a8246255af82 100644
--- a/webrtc/modules/pacing/alr_detector.h
+++ b/webrtc/modules/pacing/alr_detector.h
@@ -47,6 +47,9 @@ class AlrDetector {
int alr_bandwidth_usage_percent = kDefaultAlrBandwidthUsagePercent;
int alr_start_budget_level_percent = kDefaultAlrStartBudgetLevelPercent;
int alr_stop_budget_level_percent = kDefaultAlrStopBudgetLevelPercent;
+ // Will be sent to the receive side for stats slicing.
+ // Can be 0..6, because 3 bits are used and one value is reserved for N/A.
+ int group_id = 0;
sprang_webrtc 2017/08/24 09:13:16 Which value means N/A? Maybe easier if 0 is undefi
ilnik 2017/08/25 12:35:07 Rephrased the comment. It doesn't matter which val
};
static rtc::Optional<AlrExperimentSettings> ParseAlrSettingsFromFieldTrial(
const char* experiment_name);

Powered by Google App Engine
This is Rietveld 408576698