Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: webrtc/modules/pacing/alr_detector.h

Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension. (Closed)
Patch Set: Add metrics sliced on AlrExperiment group Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 29 matching lines...) Expand all
40 // Returns time in milliseconds when the current application-limited region 40 // Returns time in milliseconds when the current application-limited region
41 // started or empty result if the sender is currently not application-limited. 41 // started or empty result if the sender is currently not application-limited.
42 rtc::Optional<int64_t> GetApplicationLimitedRegionStartTime() const; 42 rtc::Optional<int64_t> GetApplicationLimitedRegionStartTime() const;
43 43
44 struct AlrExperimentSettings { 44 struct AlrExperimentSettings {
45 float pacing_factor = PacedSender::kDefaultPaceMultiplier; 45 float pacing_factor = PacedSender::kDefaultPaceMultiplier;
46 int64_t max_paced_queue_time = PacedSender::kMaxQueueLengthMs; 46 int64_t max_paced_queue_time = PacedSender::kMaxQueueLengthMs;
47 int alr_bandwidth_usage_percent = kDefaultAlrBandwidthUsagePercent; 47 int alr_bandwidth_usage_percent = kDefaultAlrBandwidthUsagePercent;
48 int alr_start_budget_level_percent = kDefaultAlrStartBudgetLevelPercent; 48 int alr_start_budget_level_percent = kDefaultAlrStartBudgetLevelPercent;
49 int alr_stop_budget_level_percent = kDefaultAlrStopBudgetLevelPercent; 49 int alr_stop_budget_level_percent = kDefaultAlrStopBudgetLevelPercent;
50 // Will be sent to the receive side for stats slicing.
51 // Can be 0..6, because 3 bits are used and one value is reserved for N/A.
52 int group_id = 0;
sprang_webrtc 2017/08/24 09:13:16 Which value means N/A? Maybe easier if 0 is undefi
ilnik 2017/08/25 12:35:07 Rephrased the comment. It doesn't matter which val
50 }; 53 };
51 static rtc::Optional<AlrExperimentSettings> ParseAlrSettingsFromFieldTrial( 54 static rtc::Optional<AlrExperimentSettings> ParseAlrSettingsFromFieldTrial(
52 const char* experiment_name); 55 const char* experiment_name);
53 56
54 // Sent traffic percentage as a function of network capacity used to determine 57 // Sent traffic percentage as a function of network capacity used to determine
55 // application-limited region. ALR region start when bandwidth usage drops 58 // application-limited region. ALR region start when bandwidth usage drops
56 // below kAlrStartUsagePercent and ends when it raises above 59 // below kAlrStartUsagePercent and ends when it raises above
57 // kAlrEndUsagePercent. NOTE: This is intentionally conservative at the moment 60 // kAlrEndUsagePercent. NOTE: This is intentionally conservative at the moment
58 // until BW adjustments of application limited region is fine tuned. 61 // until BW adjustments of application limited region is fine tuned.
59 static constexpr int kDefaultAlrBandwidthUsagePercent = 65; 62 static constexpr int kDefaultAlrBandwidthUsagePercent = 65;
(...skipping 10 matching lines...) Expand all
70 int alr_start_budget_level_percent_; 73 int alr_start_budget_level_percent_;
71 int alr_stop_budget_level_percent_; 74 int alr_stop_budget_level_percent_;
72 75
73 IntervalBudget alr_budget_; 76 IntervalBudget alr_budget_;
74 rtc::Optional<int64_t> alr_started_time_ms_; 77 rtc::Optional<int64_t> alr_started_time_ms_;
75 }; 78 };
76 79
77 } // namespace webrtc 80 } // namespace webrtc
78 81
79 #endif // WEBRTC_MODULES_PACING_ALR_DETECTOR_H_ 82 #endif // WEBRTC_MODULES_PACING_ALR_DETECTOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698