webrtc/common_video/include/video_frame.h - Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_video/include/video_frame.h

Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension. (Closed)

Patch Set: Add metrics sliced on AlrExperiment group Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/common_video/include/video_frame.h

diff --git a/webrtc/common_video/include/video_frame.h b/webrtc/common_video/include/video_frame.h

index 4f8ed08f9b499d9bafe8c57bfc68f262ccbaac5f..99e0b8f2a009d9a0be1ef2a6c73dd6e9cd974ef2 100644

--- a/webrtc/common_video/include/video_frame.h

+++ b/webrtc/common_video/include/video_frame.h

@@ -54,7 +54,7 @@ class EncodedImage {

size_t _length;

size_t _size;

VideoRotation rotation_ = kVideoRotation_0;

- VideoContentType content_type_ = VideoContentType::UNSPECIFIED;

+ mutable VideoContentType content_type_ = VideoContentType::UNSPECIFIED;

sprang_webrtc 2017/08/24 09:13:16 Why does it need to be mutable?

ilnik 2017/08/25 12:35:07 Because it's modified in the VCMEncodedFrameCallba

bool _completeFrame = false;

AdaptReason adapt_reason_;

int qp_ = -1; // Quantizer value.