Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2986543002: Remove RtpRtcp::RemoteRTCPStat(RTCPSenderInfo*) as unused (Closed)

Created:
3 years, 5 months ago by danilchap
Modified:
3 years, 5 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove RtpRtcp::RemoteRTCPStat(RTCPSenderInfo*) as unused BUG=webrtc:5565 Review-Url: https://codereview.webrtc.org/2986543002 Cr-Commit-Position: refs/heads/master@{#19128} Committed: https://chromium.googlesource.com/external/webrtc/+/a04d9c31a06f210ba06ca4f618250641060f9a5c

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : Add guards #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -53 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_rtcp.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 6 chunks +6 lines, -22 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
danilchap
3 years, 5 months ago (2017-07-24 10:12:44 UTC) #3
åsapersson
lgtm
3 years, 5 months ago (2017-07-25 10:19:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2986543002/60001
3 years, 5 months ago (2017-07-25 10:37:06 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-07-25 11:03:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/a04d9c31a06f210ba06ca4f61...

Powered by Google App Engine
This is Rietveld 408576698