Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc

Issue 2986543002: Remove RtpRtcp::RemoteRTCPStat(RTCPSenderInfo*) as unused (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
index bc5597f9d4aaf8f1267b6528410de2c3ca678cef..de08958ffd8da7d092c991c48c2182ed2c94ea60 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
@@ -174,8 +174,7 @@ TEST_F(RtcpReceiverTest, InvalidFeedbackPacketIsIgnored) {
}
TEST_F(RtcpReceiverTest, InjectSrPacket) {
- RTCPSenderInfo info;
- EXPECT_EQ(-1, rtcp_receiver_.SenderInfoReceived(&info));
+ EXPECT_FALSE(rtcp_receiver_.NTP(nullptr, nullptr, nullptr, nullptr, nullptr));
int64_t now = system_clock_.TimeInMilliseconds();
rtcp::SenderReport sr;
@@ -186,7 +185,7 @@ TEST_F(RtcpReceiverTest, InjectSrPacket) {
OnReceivedRtcpReceiverReport(IsEmpty(), _, now));
InjectRtcpPacket(sr);
- EXPECT_EQ(0, rtcp_receiver_.SenderInfoReceived(&info));
+ EXPECT_TRUE(rtcp_receiver_.NTP(nullptr, nullptr, nullptr, nullptr, nullptr));
}
TEST_F(RtcpReceiverTest, InjectSrPacketFromUnknownSender) {
@@ -201,8 +200,7 @@ TEST_F(RtcpReceiverTest, InjectSrPacketFromUnknownSender) {
InjectRtcpPacket(sr);
// But will not flag that he's gotten sender information.
- RTCPSenderInfo info;
- EXPECT_EQ(-1, rtcp_receiver_.SenderInfoReceived(&info));
+ EXPECT_FALSE(rtcp_receiver_.NTP(nullptr, nullptr, nullptr, nullptr, nullptr));
}
TEST_F(RtcpReceiverTest, InjectSrPacketCalculatesRTT) {
@@ -276,8 +274,6 @@ TEST_F(RtcpReceiverTest, InjectRrPacket) {
OnReceivedRtcpReceiverReport(IsEmpty(), _, now));
InjectRtcpPacket(rr);
- RTCPSenderInfo info;
- EXPECT_EQ(-1, rtcp_receiver_.SenderInfoReceived(&info));
EXPECT_EQ(now, rtcp_receiver_.LastReceivedReceiverReport());
std::vector<RTCPReportBlock> report_blocks;
rtcp_receiver_.StatisticsReceived(&report_blocks);
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698