Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2985453002: Decoupling rtc_base from apple specific code [with cyclic deps] (Closed)

Created:
3 years, 5 months ago by mbonadei
Modified:
3 years, 4 months ago
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moving apple speficic rtc_base code in another target BUG=webrtc:7743

Patch Set 1 #

Patch Set 2 : switching from public_deps to deps #

Total comments: 2

Patch Set 3 : Renaming rtc_base_apple to objc_rtc_base #

Patch Set 4 : Generate objc_rtc_base only on mac and ios #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M webrtc/rtc_base/BUILD.gn View 1 2 3 3 chunks +17 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mbonadei
3 years, 4 months ago (2017-07-26 07:19:41 UTC) #3
mbonadei
This is what we need to do in order to avoid cyclic dependencies: https://codereview.webrtc.org/2976363002/.
3 years, 4 months ago (2017-07-26 07:20:57 UTC) #4
kjellander_webrtc
https://codereview.webrtc.org/2985453002/diff/20001/webrtc/rtc_base/BUILD.gn File webrtc/rtc_base/BUILD.gn (right): https://codereview.webrtc.org/2985453002/diff/20001/webrtc/rtc_base/BUILD.gn#newcode401 webrtc/rtc_base/BUILD.gn:401: rtc_static_library("rtc_base_apple") { A name like objc_rtc_base is aligning better ...
3 years, 4 months ago (2017-07-26 07:40:38 UTC) #5
mbonadei
https://codereview.webrtc.org/2985453002/diff/20001/webrtc/rtc_base/BUILD.gn File webrtc/rtc_base/BUILD.gn (right): https://codereview.webrtc.org/2985453002/diff/20001/webrtc/rtc_base/BUILD.gn#newcode401 webrtc/rtc_base/BUILD.gn:401: rtc_static_library("rtc_base_apple") { On 2017/07/26 07:40:38, kjellander_rtc OOO Jul3-Aug11 wrote: ...
3 years, 4 months ago (2017-07-26 07:47:19 UTC) #6
kjellander_webrtc
lgtm
3 years, 4 months ago (2017-07-26 08:49:05 UTC) #7
kthelgason
lgtm
3 years, 4 months ago (2017-08-01 11:17:57 UTC) #8
mbonadei
3 years, 4 months ago (2017-08-15 07:49:02 UTC) #9
I am closing this in favor of https://codereview.webrtc.org/3001623003.

Circular dependencies are a problem we are now forced to avoid.

Powered by Google App Engine
This is Rietveld 408576698