Decoupling rtc_base from apple specific code [with cyclic deps]

webrtc/rtc_base/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/crypto.gni")
 import("//build/config/ui.gni")
@@ skipping 380 matching lines @@
     ]
   } else {
     include_dirs = [ "$rtc_jsoncpp_root" ]
 
     # When defined changes the include path for json.h to where it is
     # expected to be when building json outside of the standalone build.
     defines += [ "WEBRTC_EXTERNAL_JSON" ]
   }
 }
 
+rtc_static_library("rtc_base_apple") {

[kjellander_webrtc, 2017/07/26 07:40:38]

A name like objc_rtc_base is aligning better with established naming convention
in https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/BUILD.gn

[mbonadei, 2017/07/26 07:47:19]

Done.

+  check_includes = false
+  sources = [
+    "applefilesystem.mm",
+    "thread_darwin.mm",
+  ]
+
+  # We are explicitly disabling the check because we prefer to have a
+  # cyclic dependency instead of having to add an explicit dependency
+  # only for mac or ios on a lot of targets.
+  # deps = [ ":rtc_base" ]
+}
+
 rtc_static_library("rtc_base") {
   cflags = []
   cflags_cc = []
   libs = []
   defines = []
   deps = [
     "..:webrtc_common",
   ]
   public_deps = [
     ":rtc_base_approved",
   ]
   public_configs = []
 
   all_dependent_configs = [ ":rtc_base_all_dependent_config" ]
 
   sources = [
-    "applefilesystem.mm",
     "asyncinvoker-inl.h",
     "asyncinvoker.cc",
     "asyncinvoker.h",
     "asyncpacketsocket.cc",
     "asyncpacketsocket.h",
     "asyncresolverinterface.cc",
     "asyncresolverinterface.h",
     "asyncsocket.cc",
     "asyncsocket.h",
     "asynctcpsocket.cc",
@@ skipping 132 matching lines @@
       "ifaddrs-android.h",
     ]
 
     libs += [
       "log",
       "GLESv2",
     ]
   }
 
   if (is_ios || is_mac) {
-    sources += [
-      "macifaddrs_converter.cc",
-      "thread_darwin.mm",
-    ]
+    sources += [ "macifaddrs_converter.cc" ]
+    deps += [ ":rtc_base_apple" ]
   }
 
   if (use_x11) {
     libs += [
       "dl",
       "rt",
       "Xext",
       "X11",
       "Xcomposite",
       "Xrender",
@@ skipping 447 matching lines @@
 if (is_android) {
   android_library("base_java") {
     java_files = [
       "java/src/org/webrtc/ContextUtils.java",
       "java/src/org/webrtc/Logging.java",
       "java/src/org/webrtc/Size.java",
       "java/src/org/webrtc/ThreadUtils.java",
     ]
   }
 }