Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: webrtc/rtc_base/BUILD.gn

Issue 2985453002: Decoupling rtc_base from apple specific code [with cyclic deps] (Closed)
Patch Set: Generate objc_rtc_base only on mac and ios Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/config/crypto.gni") 9 import("//build/config/crypto.gni")
10 import("//build/config/ui.gni") 10 import("//build/config/ui.gni")
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 ] 391 ]
392 } else { 392 } else {
393 include_dirs = [ "$rtc_jsoncpp_root" ] 393 include_dirs = [ "$rtc_jsoncpp_root" ]
394 394
395 # When defined changes the include path for json.h to where it is 395 # When defined changes the include path for json.h to where it is
396 # expected to be when building json outside of the standalone build. 396 # expected to be when building json outside of the standalone build.
397 defines += [ "WEBRTC_EXTERNAL_JSON" ] 397 defines += [ "WEBRTC_EXTERNAL_JSON" ]
398 } 398 }
399 } 399 }
400 400
401 if (is_ios || is_mac) {
402 rtc_static_library("objc_rtc_base") {
403 check_includes = false
404 sources = [
405 "applefilesystem.mm",
406 "thread_darwin.mm",
407 ]
408
409 # We are explicitly disabling the check because we prefer to have a
410 # cyclic dependency instead of having to add an explicit dependency
411 # only for mac or ios on a lot of targets.
412 # deps = [ ":rtc_base" ]
413 }
414 }
415
401 rtc_static_library("rtc_base") { 416 rtc_static_library("rtc_base") {
402 cflags = [] 417 cflags = []
403 cflags_cc = [] 418 cflags_cc = []
404 libs = [] 419 libs = []
405 defines = [] 420 defines = []
406 deps = [ 421 deps = [
407 "..:webrtc_common", 422 "..:webrtc_common",
408 ] 423 ]
409 public_deps = [ 424 public_deps = [
410 ":rtc_base_approved", 425 ":rtc_base_approved",
411 ] 426 ]
412 public_configs = [] 427 public_configs = []
413 428
414 all_dependent_configs = [ ":rtc_base_all_dependent_config" ] 429 all_dependent_configs = [ ":rtc_base_all_dependent_config" ]
415 430
416 sources = [ 431 sources = [
417 "applefilesystem.mm",
418 "asyncinvoker-inl.h", 432 "asyncinvoker-inl.h",
419 "asyncinvoker.cc", 433 "asyncinvoker.cc",
420 "asyncinvoker.h", 434 "asyncinvoker.h",
421 "asyncpacketsocket.cc", 435 "asyncpacketsocket.cc",
422 "asyncpacketsocket.h", 436 "asyncpacketsocket.h",
423 "asyncresolverinterface.cc", 437 "asyncresolverinterface.cc",
424 "asyncresolverinterface.h", 438 "asyncresolverinterface.h",
425 "asyncsocket.cc", 439 "asyncsocket.cc",
426 "asyncsocket.h", 440 "asyncsocket.h",
427 "asynctcpsocket.cc", 441 "asynctcpsocket.cc",
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
560 "ifaddrs-android.h", 574 "ifaddrs-android.h",
561 ] 575 ]
562 576
563 libs += [ 577 libs += [
564 "log", 578 "log",
565 "GLESv2", 579 "GLESv2",
566 ] 580 ]
567 } 581 }
568 582
569 if (is_ios || is_mac) { 583 if (is_ios || is_mac) {
570 sources += [ 584 sources += [ "macifaddrs_converter.cc" ]
571 "macifaddrs_converter.cc", 585 deps += [ ":objc_rtc_base" ]
572 "thread_darwin.mm",
573 ]
574 } 586 }
575 587
576 if (use_x11) { 588 if (use_x11) {
577 libs += [ 589 libs += [
578 "dl", 590 "dl",
579 "rt", 591 "rt",
580 "Xext", 592 "Xext",
581 "X11", 593 "X11",
582 "Xcomposite", 594 "Xcomposite",
583 "Xrender", 595 "Xrender",
(...skipping 447 matching lines...) Expand 10 before | Expand all | Expand 10 after
1031 if (is_android) { 1043 if (is_android) {
1032 android_library("base_java") { 1044 android_library("base_java") {
1033 java_files = [ 1045 java_files = [
1034 "java/src/org/webrtc/ContextUtils.java", 1046 "java/src/org/webrtc/ContextUtils.java",
1035 "java/src/org/webrtc/Logging.java", 1047 "java/src/org/webrtc/Logging.java",
1036 "java/src/org/webrtc/Size.java", 1048 "java/src/org/webrtc/Size.java",
1037 "java/src/org/webrtc/ThreadUtils.java", 1049 "java/src/org/webrtc/ThreadUtils.java",
1038 ] 1050 ]
1039 } 1051 }
1040 } 1052 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698