Issue 2984083002: Revert "Simplify and fix implicit closure check, speed up Closure_equals"

Issue 2984083002: Revert "Simplify and fix implicit closure check, speed up Closure_equals" (Closed)

Created:
3 years, 5 months ago by alexmarkov

Modified:
3 years, 5 months ago

Reviewers:
zra, siva

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Simplify and fix implicit closure check, speed up Closure_equals" This reverts commit 44e8da3ecd23de5fdd022d6de0d2ec895cc37beb. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/45dddb28075f513479d853789a094a58df920ee8

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -170 lines)			Patch
M	runtime/lib/function.cc	View	1 chunk	+25 lines, -22 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/function_view.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/observatory/lib/src/models/objects/function.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/observatory/lib/src/service/object.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/kernel_binary_flowgraph.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	6 chunks	+4 lines, -23 lines	0 comments	Download
M	runtime/vm/object.cc	View	8 chunks	+42 lines, -44 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/source_report.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	tests/isolate/message4_test.dart	View	1 chunk	+0 lines, -69 lines	0 comments	Download

Total messages: 5 (2 generated)

alexmarkov

3 years, 5 months ago (2017-07-21 22:39:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
45dddb28075f513479d853789a094a58df920ee8 (presubmit successful).