Remove deprecated macOS SDK overrides.

Remove deprecated macOS SDK overrides.

The same overrides now live in .gn.

Bug:chromium:669240
Review-Url: https://codereview.webrtc.org/2982863002
Cr-Commit-Position: refs/heads/master@{#19030}
Committed: https://chromium.googlesource.com/external/webrtc/+/bc266bc867354136bf14df0ccae5a58c9226a98d

[erikchen, 2017-07-14 18:05:23]

erikchen@chromium.org changed reviewers:
+ tommi@webrtc.org

[erikchen, 2017-07-14 18:05:24]

tommi: Please review.

[erikchen, 2017-07-14 18:05:27]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-14 18:05:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-14 18:47:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-14 18:47:25]

Dry run: This issue passed the CQ dry run.

[tommi, 2017-07-14 21:22:34]

https://codereview.webrtc.org/2982863002/diff/1/build_overrides/build.gni
File build_overrides/build.gni (left):

https://codereview.webrtc.org/2982863002/diff/1/build_overrides/build.gni#old...
build_overrides/build.gni:11: mac_sdk_min_build_override = "10.11"
the comment says that this is used for non-Chromium builds (if I'm understanding
correctly). Are you removing this because of a problem in Chromium?  If so,
would it make more sense to set this conditionally? (i.e. only for non-Chromium
builds)

[erikchen, 2017-07-14 21:25:04]

On 2017/07/14 21:22:34, tommi (wëbrtc) wrote:
> https://codereview.webrtc.org/2982863002/diff/1/build_overrides/build.gni
> File build_overrides/build.gni (left):
> 
>
https://codereview.webrtc.org/2982863002/diff/1/build_overrides/build.gni#old...
> build_overrides/build.gni:11: mac_sdk_min_build_override = "10.11"
> the comment says that this is used for non-Chromium builds (if I'm
understanding
> correctly). Are you removing this because of a problem in Chromium?  If so,
> would it make more sense to set this conditionally? (i.e. only for
non-Chromium
> builds)

This CL is just cleanup. The variable literally has no effect anymore. The same
condition is set in webrtc/.gn.

[tommi, 2017-07-14 21:26:01]

On 2017/07/14 21:25:04, erikchen wrote:
> On 2017/07/14 21:22:34, tommi (wëbrtc) wrote:
> > https://codereview.webrtc.org/2982863002/diff/1/build_overrides/build.gni
> > File build_overrides/build.gni (left):
> > 
> >
>
https://codereview.webrtc.org/2982863002/diff/1/build_overrides/build.gni#old...
> > build_overrides/build.gni:11: mac_sdk_min_build_override = "10.11"
> > the comment says that this is used for non-Chromium builds (if I'm
> understanding
> > correctly). Are you removing this because of a problem in Chromium?  If so,
> > would it make more sense to set this conditionally? (i.e. only for
> non-Chromium
> > builds)
> 
> This CL is just cleanup. The variable literally has no effect anymore. The
same
> condition is set in webrtc/.gn.

Great, thanks for the clarification. lgtm.

[erikchen, 2017-07-14 21:26:18]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-07-14 21:26:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-14 21:29:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1500067578118650, "parent_rev":
"8b8483b27843fe7e844242794e5c5df3cb4da8ce", "commit_rev":
"bc266bc867354136bf14df0ccae5a58c9226a98d"}

[commit-bot: I haz the power, 2017-07-14 21:29:28]

Description was changed from

==========
Remove deprecated macOS SDK overrides.

The same overrides now live in .gn.

Bug:chromium:669240
==========

to

==========
Remove deprecated macOS SDK overrides.

The same overrides now live in .gn.

Bug:chromium:669240
Review-Url: https://codereview.webrtc.org/2982863002
Cr-Commit-Position: refs/heads/master@{#19030}
Committed:
https://chromium.googlesource.com/external/webrtc/+/bc266bc867354136bf14df0cc...
==========

[commit-bot: I haz the power, 2017-07-14 21:29:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/bc266bc867354136bf14df0cc...